GNOME Bugzilla – Bug 674528
afp: use the UTF-8 server name for password dialogs
Last modified: 2012-04-22 16:59:28 UTC
This fixes a crash when trying to connect to AFP volumes exported by my PowerBook; see attached patch
Created attachment 212510 [details] [review] afp: use the UTF-8 server name for password dialogs The server name might not be valid UTF-8, which will crash inside libdbus when serializing. Since we already have an UTF-8 version of the server name available, just use that.
Created attachment 212513 [details] [review] afp: convert pascal strings into utf-8 pascal strings are in the macintosh-roman character set and therefore need to be converted into utf-8.
Created attachment 212514 [details] [review] afp: use the UTF-8 server name for password dialogs when it's available
Reading the spec I don't think utf8_server_name is guaranteed to exist (it probably always does though). Although we should use it if it exists. Anyway server_name should be converted from macintosh-roman into utf-8 so that we can use it. Can you test the first patch and see if that one alone fixes the issue?
(In reply to comment #4) > Reading the spec I don't think utf8_server_name is guaranteed to exist (it > probably always does though). Although we should use it if it exists. > > Anyway server_name should be converted from macintosh-roman into utf-8 so that > we can use it. Can you test the first patch and see if that one alone fixes the > issue? Thanks for the quick reply; yes, the first patch fixes the crash for me and I like it better than my approach.
Comment on attachment 212514 [details] [review] afp: use the UTF-8 server name for password dialogs when it's available Attachment 212514 [details] pushed as a1f285f - afp: use the UTF-8 server name for password dialogs when it's available
Comment on attachment 212513 [details] [review] afp: convert pascal strings into utf-8 Attachment 212513 [details] pushed as dee21fb - afp: convert pascal strings into utf-8
Thanks, this can be closed as FIXED now.