After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674326 - Use localizations of option names and values contained in PPD files
Use localizations of option names and values contained in PPD files
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Printing
3.4.x
Other Linux
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-04-18 12:27 UTC by Marek Kašík
Modified: 2012-04-20 15:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
localize PPD option names and values (645 bytes, patch)
2012-04-18 12:27 UTC, Marek Kašík 		none Details | Review

Description Marek Kašík 2012-04-18 12:27:38 UTC 
Created attachment 212289 [details] [review]
localize PPD option names and values

Current gtk print dialog doesn't localize option names and its values even if localized versions of these strings are available. It uses default language of the PPD file.
This is a simple fix, it is enough to call ppdLocalize() after opening of the PPD file. This function localizes all the strings in the file (not changing keywords, just the strings displayed to users).

Marek
Comment 1 Matthias Clasen 2012-04-18 13:02:30 UTC 
Does that interact in any way with the localization for some important options that we do ourselves ?
Comment 2 André Klapper 2012-04-18 13:15:21 UTC 
For the records (it can be helpful to know the story behind): 
See bug 663478 comment 5.
Comment 3 Marek Kašík 2012-04-18 13:24:46 UTC 
(In reply to comment #1)
> Does that interact in any way with the localization for some important options
> that we do ourselves ?

It doesn't interact with it. If we localize an option ourselves then the dialog uses the our localization.

One thing I forgot to mention is that if there are 2 printers, one with localizations and the second one without them then the second one will not be localized while the first one will be. This makes it a little inconsistent.
Comment 4 Matthias Clasen 2012-04-18 13:26:46 UTC 
(In reply to comment #3)

> It doesn't interact with it. If we localize an option ourselves then the dialog
> uses the our localization.
>

Sounds fine then
Comment 5 Marek Kašík 2012-04-20 15:13:01 UTC 
I've committed the patch to master.

Regards

Marek