After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674215 - [patch] regression with updating tooltips
[patch] regression with updating tooltips
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
: 693430 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-04-16 18:21 UTC by Pavel Vasin
Modified: 2016-06-06 01:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.12 KB, patch)
2012-04-16 18:22 UTC, Pavel Vasin 		none Details | Review

Description Pavel Vasin 2012-04-16 18:21:28 UTC 
The commit 51189ae260699f63862a3136a552ad369d4e336a introduces regression.
The regression is that a tooltip for GtkStatusIcon (and maybe for everything else) updates only when moving mouse over icon. Normally, tooltip is updated at least once per second, even without moving mouse.
Comment 1 Pavel Vasin 2012-04-16 18:22:06 UTC 
Created attachment 212165 [details] [review]
proposed patch
Comment 2 Bug flys 2012-06-23 09:27:40 UTC 
confirmed.

The _gtk_tooltip_handle_event (&event) was triggered in
gtk_tooltip_trigger_tooltip_query (GdkDisplay *display) as the default handler.
The event was a synthesized event and didn't even have its event.motion.device
field set.

Actually, the source_device will always be NULL, with the way the event was
constructed in gtk_tooltip_trigger_tooltip_query. Since
_gtk_tooltip_handle_event() is only used this way, the touch screen testing
never reached in any situation.

The event.motion.device should be set in the _gtk_tooltip_handle_event() before
anyway can start making sense.

Still even if source_device is NULL, it still doesn't not make sense to always
return False on synthesized event. A system without input device should still be able to popup tooltips programmatically. no?
Comment 3 Jean Bréfort 2013-02-09 06:03:57 UTC 
Looks like it affects all widgets. #693430 is related to this one.
Comment 4 Jean Bréfort 2013-02-09 06:05:28 UTC 
*** Bug 693430 has been marked as a duplicate of this bug. ***