After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674165 - crash when the keyring is locked
crash when the keyring is locked
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Online Accounts
git master
Other Linux
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-16 00:21 UTC by Matthias Clasen
Modified: 2012-06-20 13:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Handle failures to store credentials in the keyring in a better way (2.70 KB, patch)
2012-04-16 12:43 UTC, Debarshi Ray 		none Details | Review
Handle failures to store credentials in the keyring in a better way (3.01 KB, patch)
2012-04-16 16:48 UTC, Debarshi Ray 		committed Details | Review
online-accounts: We might have an object even when the error is set (1.46 KB, patch)
2012-04-16 18:25 UTC, Debarshi Ray 		committed Details | Review

Description Matthias Clasen 2012-04-16 00:21:08 UTC 
I'm seeing a crash in goa_oauth_provider_add_account, in the following situation:

1. The keyring is locked
2. I set up a google account
3. after entering my google credentials, the keyring dialog pops up
4. I hit cancel
Comment 1 Debarshi Ray 2012-04-16 12:43:59 UTC 
Created attachment 212142 [details] [review]
Handle failures to store credentials in the keyring in a better way
Comment 2 Matthias Clasen 2012-04-16 12:50:48 UTC 
Review of attachment 212142 [details] [review]:

Is that the right thing, though ?

I mean, yes, we can't store the secret at this time, but is the account really 'stillborn' ?

Maybe I just don't want to store the credentials at this time, but instead will do it the next time I get the online account login dialog ?
Comment 3 Debarshi Ray 2012-04-16 16:48:10 UTC 
Created attachment 212157 [details] [review]
Handle failures to store credentials in the keyring in a better way

This exposed some bugs in the refresh_account code paths of the Exchange provider. :-)

The control center panel needs to be updated because we have changed the basic assumption that when an error occurs the returned object is NULL.
Comment 4 Debarshi Ray 2012-04-16 18:25:29 UTC 
Created attachment 212166 [details] [review]
online-accounts: We might have an object even when the error is set

This is for the GOA panel in the control center. Getting an object and error are not mutually exclusive any more.
Comment 5 Matthias Clasen 2012-06-20 01:14:38 UTC 
Review of attachment 212166 [details] [review]:

Looks good to me
Comment 6 Debarshi Ray 2012-06-20 13:08:32 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.