After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674130 - nassink hangs with audiolib error, ( pipeline never set to NULL)
nassink hangs with audiolib error, ( pipeline never set to NULL)
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
0.10.23
Other NetBSD
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-15 11:31 UTC by OHt
Modified: 2014-11-24 13:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Maybe still bad, but hopefully not worse .. (1.16 KB, text/plain)
2012-04-15 11:31 UTC, OHt 		Details

Description OHt 2012-04-15 11:31:01 UTC 
Created attachment 212080 [details]
Maybe still bad, but hopefully not worse ..

after entering :
"
gst-launch-0.10 filesrc location=anytune.mp3 ! mad ! audioconvert ! audioresample ! nassink
"
nassink hangs as in Summary above.

after doing changes in nassink.c according to attachment it works. Don't know if these changes might have any other impacts in cases not tested by me.
Comment 1 Wim Taymans 2012-04-20 10:24:55 UTC 
I pushed a different version into the 0.10 branch. It contains some cleanups, the sequence of nas calls should be like your changes. Can you test and reopen this bug when it's not working? I tried running nasd but it relies on OSS...

commit 67c8ae01be7b0023b63df12ca3ad276b1f5d8082
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Fri Apr 20 12:09:08 2012 +0200

    nas: Rework nassink a little
    
    Based on patch from <ole.hellqvist at spray.se>
    Create and destroy flow in prepare/unprepare
    Remove some duplicate code from close and prepare that is now in unprepare.
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=674130
Comment 2 OHt 2012-04-20 17:24:42 UTC 
he old symptom was back...
new problem is that as the unprep function is activated after the close function the nas server is set to null, this makes the  "NAS_flush" function go crazy as it uses the server id for event handeling.
I,ve added the line :    if (  sink->audio != NULL)
before " NAS_flush (sink);"
Making the call in unprep conditional.
An alternative would be to have some error handleling in NAS_flush.
after that it worked ...
Comment 3 Tim-Philipp Müller 2012-04-20 22:31:46 UTC 
Reopening then..
Comment 4 Sebastian Dröge (slomo) 2014-01-03 13:04:55 UTC 
Is this still a problem with 1.x?
Comment 5 Tim-Philipp Müller 2014-11-24 13:43:24 UTC 
The nas plugin hasn't been ported, and it doesn't look like anyone is working on it, so I would say let's close this.