After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 674126 - util_find_program_in_path() fails to find utilities in /sbin and /usr/sbin
util_find_program_in_path() fails to find utilities in /sbin and /usr/sbin
Status: RESOLVED FIXED
Product: gnome-nettool
Classification: Applications
Component: general
3.2.x
Other Linux
: Normal normal
: ---
Assigned To: Germán Poo-Caamaño
Rodrigo Moya
Depends on:
Blocks:
 
 
Reported: 2012-04-15 06:49 UTC by Alexandre Rostovtsev
Modified: 2012-10-02 02:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (2.26 KB, patch)
2012-04-15 06:51 UTC, Alexandre Rostovtsev 		committed Details | Review

Description Alexandre Rostovtsev 2012-04-15 06:49:56 UTC 
gnome-nettool tries to use some utilities which, at least in some distros, are installed in /sbin or /usr/sbin; for example, tracepath is installed in /usr/sbin on Gentoo.

Since util_find_program_in_path(program, NULL) searches only in the user's path, which doesn't have /sbin and /usr/sbin in it by default, gnome-nettool fails to find them.

A simple solution is to always append EXTRA_PATH (already defined in utils.c) to the user's path before searching.
Comment 1 Alexandre Rostovtsev 2012-04-15 06:51:01 UTC 
Created attachment 212073 [details] [review]
proposed patch
Comment 2 Germán Poo-Caamaño 2012-10-02 02:51:32 UTC 
Review of attachment 212073 [details] [review]:

It makes sense. Thanks.
Comment 3 Germán Poo-Caamaño 2012-10-02 02:52:09 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.