GNOME Bugzilla – Bug 674091
a52dec: update to compile against liba52 git master
Last modified: 2012-05-17 11:27:44 UTC
"Official" liba52 [1] is 10 years old. The most recent "unofficial" liba52 is hosted at [2] and was updated the last time at 2009-12 (less than 3 years old), and had 21 patch since it forked from [1]. a52dec should link to [2] instead of [1]. [1] http://liba52.sourceforge.net/ [2] svn://svn.videolan.org/liba52
Created attachment 212035 [details] [review] Update to liba52 git master a52_init() doesn't have arguments now. It used to take CPU flags, but now CPU capabilities are autodetected. Hence cpuflags attribute in gsta52dec can be removed, as well as the dependency on ORC for CPU capability detection.
Comment on attachment 212035 [details] [review] Update to liba52 git master Just requiring the other version isn't particularly helpful, esp. if the changes are so minor. We should detect and support both. Is there a define somewhere in the headers that would allow us to tell them apart?
Created attachment 212089 [details] A diff between original liba52 and videolan version From the looks of things, you can anchor on A52_ACCEL_DETECT. Also, i'm starting to doubt the correctness of my patch. I guess it depends on the intentions you have. I'm not sure it makes much sense to tell a52 which acceleration options to use, if a52 can autodetect them, especially if gst itself autodetects them too.
Created attachment 212096 [details] [review] Adapt existing code to work with newer liba52 ifdefs some parts of the code depending on A52_ACCEL_DETECT, maintaining (hopefully) compatibility with liba52-0.7.4. There's also a strange sizeof(a52_state_t) configure check. It fails, but gsta52 is compiled nevertheless. Can you check that -ugly still compiles against 0.7.4 with this patch? I don't have 0.7.4 readily available.
Still works for me (0.7.4) with patch applied.
commit b199334a6bcfb384a9cbe8f93c5d1dce1622c1b6 Author: Руслан Ижбулатов <lrn1986@gmail.com> Date: Sun Apr 15 23:39:48 2012 +0400 a52dec: adapt to work also with new liba52 Fixes https://bugzilla.gnome.org/show_bug.cgi?id=674091