GNOME Bugzilla – Bug 674010
Fix libmusicbrainz .pc installation path
Last modified: 2012-05-21 12:57:42 UTC
Without specifying LIB_SUFFIX, the .pc ends up installed to $prefix/lib, even if jhbuild is set to use_lib64.
Created attachment 211951 [details] [review] cmake: allow substituion of libsuffix variable libmusicbrainz uses a libsuffix value, "32" or "64"
Created attachment 211952 [details] [review] core-deps-3.[4,6]: fix libmusicbrainz .pc installation Use custom cmake args with ${libsuffix} to fix installation path of .pc
Review of attachment 211951 [details] [review]: Thank you for the patch. On a 32bit system, your patch would cause some of libmusicbrainz to be installed to /opt/gnome/lib32. On 32bit systems, JHBuild packages install in /opt/gnome/lib
Created attachment 213553 [details] [review] cmake: allow substituion of libsuffix variable libmusicbrainz uses a libsuffix value, "32" or "64"
Comment on attachment 213553 [details] [review] cmake: allow substituion of libsuffix variable Thank you for your patch. I reworked [1] eval_args in an earlier commit. So I changed your patch to call the parent class eval_args, and committed here: http://git.gnome.org/browse/jhbuild/commit/?id=1a24440667b0696096a4ce7800ada2b80a9e8e89 [1] http://git.gnome.org/browse/jhbuild/commit/?id=4b85c395c57cf16636e54901e2658a87b3956aa9
Comment on attachment 211952 [details] [review] core-deps-3.[4,6]: fix libmusicbrainz .pc installation Committed. http://git.gnome.org/browse/jhbuild/commit/?id=36b2a50fa9374dab58f2f3cc8b55cf873198f356