After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673961 - Mismatching AC_DEFINE for XI 2.2 support
Mismatching AC_DEFINE for XI 2.2 support
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: x11
git master
Other Linux
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-12 03:06 UTC by Peter Hutterer
Modified: 2012-04-12 10:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-Rename-XINPUT_2_2-define-to-HAVE_XINPUT_2_2.patch (6.00 KB, patch)
2012-04-12 03:06 UTC, Peter Hutterer 		committed Details | Review

Description Peter Hutterer 2012-04-12 03:06:45 UTC 
Created attachment 211893 [details] [review]
0001-Rename-XINPUT_2_2-define-to-HAVE_XINPUT_2_2.patch

configure.ac defines XINPUT_2_2 if XI 2.2 support was found. The code expects XINPUT_2_2 in the device manager, but HAVE_XINPUT_2_2 in the x11 backend.

On newer X servers, the latter causes a BadValue when XIQueryDevice sends a different major/minor than gdk's device manager (gnome-control-center).

Attached patch changes all occurrences to HAVE_XINPUT_2_2, for consistency with HAVE_XINPUT_2
Comment 1 Emmanuele Bassi (:ebassi) 2012-04-12 09:40:14 UTC 
Review of attachment 211893 [details] [review]:

ouch. looks good, thanks for the patch.
Comment 2 Emmanuele Bassi (:ebassi) 2012-04-12 10:38:29 UTC 
pushed to master and the clutter-1.10 branch.