After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673954 - glchess: changing the Promotion type setting does not reflect in next game.
glchess: changing the Promotion type setting does not reflect in next game.
Status: RESOLVED FIXED
Product: gnome-chess
Classification: Applications
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on: 655761
Blocks: 664972
 
 
Reported: 2012-04-11 23:08 UTC by Chandni Verma
Modified: 2012-12-20 02:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[glchess] Make use of promotion-type setting (3.23 KB, patch)
2012-05-01 01:26 UTC, Chandni Verma 		needs-work Details | Review

Description Chandni Verma 2012-04-11 23:08:30 UTC 
I see the setting "promotion-type" being set but not being retrieved in the code. Instead, the values for promotion type going as parameters to ChessState : move_with_coords () function are hard-coded to PieceType.QUEEN.

Can someone confirm the bug if you are able to reproduce it?
Comment 1 Robert Ancell 2012-04-11 23:42:53 UTC 
Confirmed.
Comment 2 Chandni Verma 2012-04-11 23:45:32 UTC 
OK, my branch includes a patch :)
Comment 3 Chandni Verma 2012-04-20 04:42:18 UTC 
Refer: https://bugzilla.gnome.org/show_bug.cgi?id=655761#c6

The branch includes a fix for this one.
Comment 4 Robert Ancell 2012-04-29 21:56:19 UTC 
Chandi,

Could you convert that change into a patch with git format-patch and attach here?  Then we can review using the bugzilla review tools.
Comment 5 Chandni Verma 2012-05-01 01:26:36 UTC 
Created attachment 213161 [details] [review]
[glchess] Make use of promotion-type setting

Fixes:
Comment 6 Robert Ancell 2012-05-03 02:07:35 UTC 
Review of attachment 213161 [details] [review]:

Requires other set of patches so can't be applied as is.  Also like the other patches the piece type is being set too late.
Comment 7 Chandni Verma 2012-12-20 02:58:04 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.