After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673882 - application-window: try to use the desktop name in the fallback menu
application-window: try to use the desktop name in the fallback menu
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkApplication
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-04-10 22:50 UTC by Cosimo Cecchi
Modified: 2012-04-13 01:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
application-window: try to use the desktop name in the fallback menu (2.53 KB, patch)
2012-04-10 22:50 UTC, Cosimo Cecchi 		none Details | Review
build: split out a HAVE_GIO_UNIX config variable (2.27 KB, patch)
2012-04-11 14:25 UTC, Cosimo Cecchi 		none Details | Review
application-window: try to use the desktop name in the fallback menu (2.57 KB, patch)
2012-04-11 14:25 UTC, Cosimo Cecchi 		none Details | Review
application-window: try to use the desktop name in the fallback menu (2.57 KB, patch)
2012-04-13 01:53 UTC, Matthias Clasen 		committed Details | Review
build: split out a HAVE_GIO_UNIX config variable (2.27 KB, patch)
2012-04-13 01:53 UTC, Matthias Clasen 		committed Details | Review

Description Cosimo Cecchi 2012-04-10 22:50:36 UTC 
See attached patch.
Comment 1 Cosimo Cecchi 2012-04-10 22:50:38 UTC 
Created attachment 211798 [details] [review]
application-window: try to use the desktop name in the fallback menu

Try to fetch the name from the application desktop file for the
fallback menu if possible, instead of forcing applications to use
g_set_application_name or hardcoding "Application".
Comment 2 Cosimo Cecchi 2012-04-11 14:25:02 UTC 
Created attachment 211830 [details] [review]
build: split out a HAVE_GIO_UNIX config variable

We'll use it in GtkApplicationWindow, since we need to conditionally
depend on gio-unix there.
Comment 3 Cosimo Cecchi 2012-04-11 14:25:41 UTC 
Created attachment 211831 [details] [review]
application-window: try to use the desktop name in the fallback menu

New patches that enable the feature conditionally to the presence of gio-unix, and not according to the GDK backend.
Comment 4 Matthias Clasen 2012-04-13 01:53:17 UTC 
The following fixes have been pushed:
398ba38 application-window: try to use the desktop name in the fallback menu
1713cbe build: split out a HAVE_GIO_UNIX config variable
Comment 5 Matthias Clasen 2012-04-13 01:53:24 UTC 
Created attachment 211966 [details] [review]
application-window: try to use the desktop name in the fallback menu

Try to fetch the name from the application desktop file for the
fallback menu if possible, instead of forcing applications to use
g_set_application_name or hardcoding "Application".
Comment 6 Matthias Clasen 2012-04-13 01:53:27 UTC 
Created attachment 211967 [details] [review]
build: split out a HAVE_GIO_UNIX config variable

We'll use it in GtkApplicationWindow, since we need to conditionally
depend on gio-unix there.