After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673847 - express: Make use of 'distro' data from libosinfo
express: Make use of 'distro' data from libosinfo
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: installer
unspecified
Other All
: Normal normal
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-04-10 15:38 UTC by Zeeshan Ali
Modified: 2016-03-31 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
express: Make use of 'distro' data from libosinfo (1.94 KB, patch)
2012-04-10 15:38 UTC, Zeeshan Ali 		committed Details | Review

Description Zeeshan Ali 2012-04-10 15:38:43 UTC 
Make use of 'distro' data from libosinfo.
Comment 1 Zeeshan Ali 2012-04-10 15:38:45 UTC 
Created attachment 211761 [details] [review]
express: Make use of 'distro' data from libosinfo

No need to hardcode each fedora version anymore.
Comment 2 Marc-Andre Lureau 2012-04-10 17:02:28 UTC 
Review of attachment 211761 [details] [review]:

ack

::: src/media-manager.vala
@@ +111,3 @@
             return new FedoraInstaller.copy (media);
 
+        case "win":

(I feel like "windows" would have been a more sensible "distro" name choice)
Comment 3 Zeeshan Ali 2012-04-10 19:27:35 UTC 
(In reply to comment #2)
> ::: src/media-manager.vala
> @@ +111,3 @@
>              return new FedoraInstaller.copy (media);
> 
> +        case "win":
> 
> (I feel like "windows" would have been a more sensible "distro" name choice)

Agreed but you'll need to talk to danpb about this.
Comment 4 Zeeshan Ali 2012-04-10 19:31:58 UTC 
Attachment 211761 [details] pushed as 05049ff - express: Make use of 'distro' data from libosinfo