After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673821 - Remove old contact list code
Remove old contact list code
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Contact List
2.33.x
Other Linux
: Normal enhancement
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-10 08:57 UTC by Guillaume Desmottes
Modified: 2012-04-10 12:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
tp-chat: port to Telepathy coding style (89.12 KB, patch)
2012-04-10 11:31 UTC, Guillaume Desmottes 		committed Details | Review
tp-chat: use self->priv directly (3.64 KB, patch)
2012-04-10 11:31 UTC, Guillaume Desmottes 		committed Details | Review
implement empathy_tp_chat_add as a method on TpChat (3.62 KB, patch)
2012-04-10 11:32 UTC, Guillaume Desmottes 		committed Details | Review
remove unused tp_chat_remove (1.46 KB, patch)
2012-04-10 11:32 UTC, Guillaume Desmottes 		committed Details | Review
implement empathy_tp_chat_get_members as a method on TpChat (3.88 KB, patch)
2012-04-10 11:32 UTC, Guillaume Desmottes 		committed Details | Review
remove useless empathy-contact-list.h includes (3.52 KB, patch)
2012-04-10 11:32 UTC, Guillaume Desmottes 		committed Details | Review
remove empathy-contact-list (11.68 KB, patch)
2012-04-10 11:32 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2012-04-10 08:57:44 UTC 
In the new API we trust.
Comment 1 Guillaume Desmottes 2012-04-10 11:31:53 UTC 
Created attachment 211718 [details] [review]
tp-chat: port to Telepathy coding style

I'm so tired of hacking in this file using the old style.
Comment 2 Guillaume Desmottes 2012-04-10 11:31:56 UTC 
Created attachment 211719 [details] [review]
tp-chat: use self->priv directly
Comment 3 Guillaume Desmottes 2012-04-10 11:32:00 UTC 
Created attachment 211720 [details] [review]
implement empathy_tp_chat_add as a method on TpChat

We want to get rid of the EmpathyContactList interface.
Comment 4 Guillaume Desmottes 2012-04-10 11:32:03 UTC 
Created attachment 211721 [details] [review]
remove unused tp_chat_remove

empathy_contact_list_remove() is not used any more.
Comment 5 Guillaume Desmottes 2012-04-10 11:32:06 UTC 
Created attachment 211722 [details] [review]
implement empathy_tp_chat_get_members as a method on TpChat

That means EmpathyTpChat doesn't have to implement the EmpathyContactList
interface any more.
Comment 6 Guillaume Desmottes 2012-04-10 11:32:09 UTC 
Created attachment 211723 [details] [review]
remove useless empathy-contact-list.h includes
Comment 7 Guillaume Desmottes 2012-04-10 11:32:12 UTC 
Created attachment 211724 [details] [review]
remove empathy-contact-list
Comment 9 Guillaume Desmottes 2012-04-10 12:10:36 UTC 
Attachment 211718 [details] pushed as 6ed0e77 - tp-chat: port to Telepathy coding style
Attachment 211719 [details] pushed as 8e3b02e - tp-chat: use self->priv directly
Attachment 211720 [details] pushed as b659326 - implement empathy_tp_chat_add as a method on TpChat
Attachment 211721 [details] pushed as 869f0b9 - remove unused tp_chat_remove
Attachment 211722 [details] pushed as c3a3fdb - implement empathy_tp_chat_get_members as a method on TpChat
Attachment 211723 [details] pushed as a5dd270 - remove useless empathy-contact-list.h includes
Attachment 211724 [details] pushed as 18c0cad - remove empathy-contact-list