After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673766 - Rotation combo box items do not appear localized
Rotation combo box items do not appear localized
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Display
3.4.x
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-04-09 06:56 UTC by Gabor Kelemen
Modified: 2012-04-10 15:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Trivial patch: use correct function (1.32 KB, patch)
2012-04-09 07:00 UTC, Gabor Kelemen 		committed Details | Review

Description Gabor Kelemen 2012-04-09 06:56:26 UTC 
The rotation combo box items on the Displays panel do not appear translated. This is because the items got translation context support in [0], but to get the localized strings, one needs to use g_dpgettext2()[1], not gettext(). This change didn't happened.

[0]: http://git.gnome.org/browse/gnome-control-center/commit/panels/display/cc-display-panel.c?id=5a5a037d09787da48f3c8b60ca5ce6dcb5ebcbf3
[1]: http://developer.gnome.org/glib/stable/glib-I18N.html#NC-:CAPS
Comment 1 Gabor Kelemen 2012-04-09 07:00:42 UTC 
Created attachment 211612 [details] [review]
Trivial patch: use correct function
Comment 2 Matthias Clasen 2012-04-10 02:09:22 UTC 
Could just use C_() here
Comment 3 Matthias Clasen 2012-04-10 02:09:45 UTC 
actually, no, you can't
Comment 4 Bastien Nocera 2012-04-10 15:04:25 UTC 
Committed with a more verbose commit message, and coding style fixes. Thanks!