Created attachment 211500 [details] [review]
Fix documentation warnings

gobject-introspection now emits many more warnings for malformed
comments, and they fail the build.

Review of attachment 211500 [details] [review]:

One comment, otherwise looks great:

::: src/st/st-types.h
@@ +16,3 @@
  */
 
+#ifndef __GI_SCANNER__

Why?

Because st-types.h is included from all source files, so g-ir-scanner sees that comment multiple times and complains.
Maybe it can be considered a bug in gobject-introspection, but that seemed the fastest fix.

(In reply to comment #3)
> Because st-types.h is included from all source files, so g-ir-scanner sees that
> comment multiple times and complains.
> Maybe it can be considered a bug in gobject-introspection, but that seemed the
> fastest fix.

That's clearly a bug. The hardest part of fixing this is creating a reproducible test case for g-i, can you help out with that?

OK, it's our bug. Just moving the comment inside the header guards fixes it.

And Giovanni, can you port the gvc changes "upstream" (I think gnome-control-center and gnome-settings-daemon have copies)

Created attachment 211540 [details] [review]
Fix documentation warnings

gobject-introspection now emits many more warnings for malformed
comments, and they fail the build.


Found in IRC the cause of the problem, SECTION:st-types was not
protected by header guards.

Review of attachment 211540 [details] [review]:

Looks fine.

Ping? This is breaking the build -- a push would be appreciated.

( mutter is still broken, the fix for that is in bug #673752 )

Attachment 211540 [details] pushed as 55a4517 - Fix documentation warnings
Sorry, I had system problems yesterday
(not counting it was easter...)