After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673628 - properly quote UDEV_REQUIRED in configure check
properly quote UDEV_REQUIRED in configure check
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
3.4.x
Other Linux
: Normal normal
: 3.4
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-04-06 08:31 UTC by Michael Biebl
Modified: 2012-04-06 08:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] build: Properly quote $UDEV_REQUIRED variable (855 bytes, patch)
2012-04-06 08:33 UTC, Michael Biebl 		committed Details | Review

Description Michael Biebl 2012-04-06 08:31:09 UTC 
configure.ac has
AS_IF([test -n $UDEV_REQUIRED]

On systems where GUdev is not installed, this test fails, though, as the UDEV_REQUIRED variable needs proper quoting.
See e.g. https://buildd.debian.org/status/fetch.php?pkg=cheese&arch=kfreebsd-amd64&ver=3.4.0-1&stamp=1333657441

Proposed patch attached
Comment 1 Michael Biebl 2012-04-06 08:33:15 UTC 
Created attachment 211453 [details] [review]
[PATCH] build: Properly quote $UDEV_REQUIRED variable
Comment 2 David King 2012-04-06 08:40:22 UTC 
Comment on attachment 211453 [details] [review]
[PATCH] build: Properly quote $UDEV_REQUIRED variable

Pushed to gnome-3-4 and master as commits 4bd22847e23108eb0a2f4b95b549f734f0c1f0fb and 1d1aa7be13ab4705a1e8231fb194563cefb069be, thanks.