After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673595 - gnome-settings-daemon: fix applying settings to newly added touchpads
gnome-settings-daemon: fix applying settings to newly added touchpads
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: mouse
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-settings-daemon-maint
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2012-04-05 17:20 UTC by Owen Taylor
Modified: 2012-04-05 17:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gnome-settings-daemon: fix applying settings to newly added touchpads (2.36 KB, patch)
2012-04-05 17:20 UTC, Owen Taylor 		committed Details | Review

Description Owen Taylor 2012-04-05 17:20:26 UTC 
This fixes touchpads not being disabled when resuming from suspend.

(It's possible that the right thing to do might be to just remove the
check - after all, no check is done on device type in initial setup in
gsd_mouse_manager_idle_cb())
Comment 1 Owen Taylor 2012-04-05 17:20:29 UTC 
Created attachment 211417 [details] [review]
gnome-settings-daemon: fix applying settings to newly added touchpads

In GTK+-3.4, touchpads no longer are classified as GDK_SOURCE_MOUSE,
they are GDK_SOURCE_TOUCHPAD, so we need to add a check for that
in the handling for newly added devices, or touchpads won't get
configured properly when returning from suspend.

Required GTK+ version is bumped to 3.3.18 for the GDK_SOURCE_TOUCHPAD
enum value.
Comment 2 Bastien Nocera 2012-04-05 17:27:42 UTC 
Review of attachment 211417 [details] [review]:

Looks good for gnome-3-4 and master.

::: plugins/mouse/gsd-mouse-manager.c
@@ +1015,3 @@
                  GsdMouseManager  *manager)
 {
+        GdkInputSource source = gdk_device_get_source (device);

Separate into 3 lines:
GdkInputSource source;

source = ...;

@@ +1036,3 @@
                    GsdMouseManager  *manager)
 {
+        GdkInputSource source = gdk_device_get_source (device);

Ditto.
Comment 3 Owen Taylor 2012-04-05 17:33:20 UTC 
Pushed to origin and gnome-3-4 with the requested change.

Attachment 211417 [details] pushed as 3a16a83 - gnome-settings-daemon: fix applying settings to newly added touchpads