After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673439 - Properly deprecate g_value_{set,get}_char
Properly deprecate g_value_{set,get}_char
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-04-03 14:36 UTC by Guillaume Desmottes
Modified: 2012-04-03 16:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
use GLIB_DEPRECATED_IN_2_32_FOR to deprecate g_value_{g,s}et_schar (1.03 KB, patch)
2012-04-03 14:37 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2012-04-03 14:36:54 UTC 
GLIB_DEPRECATED_IN_2_32_FOR ftw!
Comment 1 Guillaume Desmottes 2012-04-03 14:37:43 UTC 
Created attachment 211228 [details] [review]
use GLIB_DEPRECATED_IN_2_32_FOR to deprecate g_value_{g,s}et_schar
Comment 2 Colin Walters 2012-04-03 14:40:05 UTC 
Review of attachment 211228 [details] [review]:

Looks correct.
Comment 3 Guillaume Desmottes 2012-04-03 14:46:30 UTC 
Attachment 211228 [details] pushed as 091d652 - use GLIB_DEPRECATED_IN_2_32_FOR to deprecate g_value_{g,s}et_schar
Comment 4 Xavier Claessens 2012-04-03 14:50:13 UTC 
Shouldn't this be pushed to 2.30 branch as well?
Comment 5 Colin Walters 2012-04-03 14:57:06 UTC 
(In reply to comment #4)
> Shouldn't this be pushed to 2.30 branch as well?

No, because GLIB_DEPRECATED_FOR is new in 2.32.
Comment 6 Dan Winship 2012-04-03 15:04:26 UTC 
ah, the commit message is wrong, but the patch is right. (it's the _char methods that are deprecated, not the _schar ones)
Comment 7 Xavier Claessens 2012-04-03 16:27:11 UTC 
(In reply to comment #5)
> (In reply to comment #4)
> > Shouldn't this be pushed to 2.30 branch as well?
> 
> No, because GLIB_DEPRECATED_FOR is new in 2.32.

Sorry I meant 2.32 branch but glib did not branch yet it seems.