After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673259 - The gdk/gdkkeysyms-update.pl script and the keysym files generated by it are outdated
The gdk/gdkkeysyms-update.pl script and the keysym files generated by it are ...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
unspecified
Other All
: Normal trivial
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-03-31 20:18 UTC by Mark Vender
Modified: 2012-04-26 00:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update the keysym files (15.84 KB, patch)
2012-03-31 20:18 UTC, Mark Vender 		reviewed Details | Review
Fix the gdk/gdkkeysyms-update.pl to reflect new upstream location (5.29 KB, patch)
2012-04-12 12:06 UTC, Mark Vender 		accepted-commit_now Details | Review
Regenerate the gdk/gdkkeysyms.h and gdk/gdkkeysyms-compat.h files (10.78 KB, patch)
2012-04-12 12:07 UTC, Mark Vender 		accepted-commit_now Details | Review

Description Mark Vender 2012-03-31 20:18:46 UTC 
Created attachment 211041 [details] [review]
Update the keysym files

The gdk/gdkkeysyms-update.pl script can no longer download X11 protocol headers to build the keysym files, as the upstream location has changed. The attached patch fixes this issue and regenerates the keysym files on the occasion.
Comment 1 Matthias Clasen 2012-04-03 15:35:38 UTC 
Review of attachment 211041 [details] [review]:

Can you split this into two separate commits ? One for the script update, and a separate one for the headers
Comment 2 Mark Vender 2012-04-12 12:06:27 UTC 
Created attachment 211921 [details] [review]
Fix the gdk/gdkkeysyms-update.pl to reflect new upstream location

Sure.
Comment 3 Mark Vender 2012-04-12 12:07:46 UTC 
Created attachment 211922 [details] [review]
Regenerate the gdk/gdkkeysyms.h and gdk/gdkkeysyms-compat.h files
Comment 4 Mark Vender 2012-04-24 18:02:53 UTC 
Are there further problems with this patch that prevent it from being pushed?
Comment 5 Matthias Clasen 2012-04-24 18:06:11 UTC 
Sorry, I forgot about this bug.
Comment 6 Matthias Clasen 2012-04-24 18:16:27 UTC 
Review of attachment 211921 [details] [review]:

Should get committed to the 3.4 branch as well.
Comment 7 Matthias Clasen 2012-04-24 18:16:50 UTC 
Review of attachment 211922 [details] [review]:

Should get committed to the 3.4 branch as well