After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673237 - window: Remove needless call to ensure_state_flag_backdrop() on map
window: Remove needless call to ensure_state_flag_backdrop() on map
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-03-31 14:28 UTC by Rui Matos
Modified: 2012-05-04 00:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
window: Remove needless call to ensure_state_flag_backdrop() on map (1020 bytes, patch)
2012-03-31 14:28 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2012-03-31 14:28:47 UTC 
While working on bug 673125 I noticed that this doesn't seem to be needed.
Comment 1 Rui Matos 2012-03-31 14:28:49 UTC 
Created attachment 211032 [details] [review]
window: Remove needless call to ensure_state_flag_backdrop() on map

This call was forcing needless work since gtk_window_map() already
does a gdk_window_show() which initially sets GDK_WINDOW_STATE_FOCUSED
that we then handle regularly on the widget's window state event
handler.
Comment 2 Matthias Clasen 2012-04-06 23:44:33 UTC 
Review of attachment 211032 [details] [review]:

ok
Comment 3 Allison Karlitskaya (desrt) 2012-05-04 00:24:55 UTC 
Attachment 211032 [details] pushed as 4d7c7ec - window: Remove needless call to ensure_state_flag_backdrop() on map