After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 673219 - incorrect definition of compatibility AvailabilityMacros (MAC_OS_X_VERSION_10_X)
incorrect definition of compatibility AvailabilityMacros (MAC_OS_X_VERSION_10_X)
Status: RESOLVED FIXED
Product: doxygen
Classification: Other
Component: build
1.8.0
Other Mac OS
: Normal normal
: ---
Assigned To: Dimitri van Heesch
Dimitri van Heesch
Depends on:
Blocks:
 
 
Reported: 2012-03-31 02:56 UTC by Ryan Schmidt
Modified: 2012-05-19 12:26 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed patch (1.21 KB, application/octet-stream)
2012-03-31 02:56 UTC, Ryan Schmidt
  Details
proposed patch (1.21 KB, patch)
2012-03-31 02:57 UTC, Ryan Schmidt
none Details | Review

Description Ryan Schmidt 2012-03-31 02:56:14 UTC
qtools/qglobal.h includes <AvailabilityMacros.h> and then adds defines for any newer versions of OS X. But the defines are defined incorrectly. AvailabilityMacros.h on my OS X 10.6 system shows the defines being defined as follows -- each version increases by ten:

#define MAC_OS_X_VERSION_10_0 1000
#define MAC_OS_X_VERSION_10_1 1010
#define MAC_OS_X_VERSION_10_2 1020
#define MAC_OS_X_VERSION_10_3 1030
#define MAC_OS_X_VERSION_10_4 1040
#define MAC_OS_X_VERSION_10_5 1050
#define MAC_OS_X_VERSION_10_6 1060

But qglobal.h defines them like this -- with each version increasing by one: 

#  if !defined(MAC_OS_X_VERSION_10_3)
#     define MAC_OS_X_VERSION_10_3 MAC_OS_X_VERSION_10_2 + 1
#  endif
#  if !defined(MAC_OS_X_VERSION_10_4)
#       define MAC_OS_X_VERSION_10_4 MAC_OS_X_VERSION_10_3 + 1
#  endif
#  if !defined(MAC_OS_X_VERSION_10_5)
#       define MAC_OS_X_VERSION_10_5 MAC_OS_X_VERSION_10_4 + 1
#  endif
#  if !defined(MAC_OS_X_VERSION_10_6)
#       define MAC_OS_X_VERSION_10_6 MAC_OS_X_VERSION_10_5 + 1
#  endif
#  if !defined(MAC_OS_X_VERSION_10_7)
#       define MAC_OS_X_VERSION_10_7 MAC_OS_X_VERSION_10_6 + 1
#  endif

The attached patch fixes this.
Comment 1 Ryan Schmidt 2012-03-31 02:56:58 UTC
Created attachment 211014 [details]
proposed patch
Comment 2 Ryan Schmidt 2012-03-31 02:57:38 UTC
Created attachment 211015 [details] [review]
proposed patch
Comment 3 Dimitri van Heesch 2012-04-04 18:20:32 UTC
Hi Ryan,

I doubt that this will make a functional difference, but I agree it is better to use the same versioning scheme as Apple does.
Comment 4 Dimitri van Heesch 2012-05-19 12:26:37 UTC
This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.8.1. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information
that you think can be relevant.