After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 672956 - [patch] wrong use of shadow-type = in for some viewports
[patch] wrong use of shadow-type = in for some viewports
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-03-27 21:49 UTC by Cosimo Cecchi
Modified: 2012-04-30 12:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell: don't set a shadow type on the GtkViewport (892 bytes, patch)
2012-03-27 21:49 UTC, Cosimo Cecchi 		committed Details | Review
bluetooth: don't set a shadow type on the viewport (1.40 KB, patch)
2012-03-27 21:49 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2012-03-27 21:49:25 UTC 
Until now, Adwaita didn't render borders for certain types of widgets (e.g. GtkViewports and GtkFrames), despite their shadow-type setting.
This is going to change with Adwaita 3.5 - git master already renders frames for these two widgets. Doing that highlighted some bugs in the way we set shadow-type for certain widgets in the control center, see attached patches.
Comment 1 Cosimo Cecchi 2012-03-27 21:49:27 UTC 
Created attachment 210734 [details] [review]
shell: don't set a shadow type on the GtkViewport
Comment 2 Cosimo Cecchi 2012-03-27 21:49:29 UTC 
Created attachment 210735 [details] [review]
bluetooth: don't set a shadow type on the viewport
Comment 3 Cosimo Cecchi 2012-04-29 22:28:03 UTC 
Can we get these in for 3.5.1?
Comment 4 Bastien Nocera 2012-04-30 00:02:53 UTC 
Review of attachment 210734 [details] [review]:

Looks good
Comment 5 Bastien Nocera 2012-04-30 00:13:05 UTC 
Review of attachment 210735 [details] [review]:

Looks good too
Comment 6 Cosimo Cecchi 2012-04-30 12:49:38 UTC 
Attachment 210734 [details] pushed as 5edec81 - shell: don't set a shadow type on the GtkViewport
Attachment 210735 [details] pushed as 656862e - bluetooth: don't set a shadow type on the viewport