GNOME Bugzilla – Bug 672675
Themes need translatable names
Last modified: 2018-03-03 16:17:00 UTC
The strings "balls" and "shapes" (drop-down menu) are not translatable in the preferences window. best regards
Mahjongg is a good example of how to solve this.
I am trying to see if my changes work but I am not sure how I should go about testing. The package seems to be building, but I am not sure how to generate the .po files. Can you point me in the right direction? Thanks
(In reply to Ruxandra Simion from comment #2) > I am trying to see if my changes work but I am not sure how I should go > about testing. The package seems to be building, but I am not sure how to > generate the .po files. Can you point me in the right direction? Thanks Hm, .po files are generated by translators; I've never made one before. Really, you just want to ensure that the new strings appear in the pot file, but if you want to update the po file for a particular locale to give you more confidence that your change is correct, that's great too. I believe there are several different tools that can generate po files and the pot file. Piotr is CCed, maybe he can point you in the right direction.
Until your work in bug #793042 is merged, you can just run “intltool-update -p” to generate the .pot file, or “intltool-update XX” to generate the .pot file and update a .po file for XX language.
(Forgot to note, you need to run these commands in the po/ directory.)
Created attachment 368891 [details] [review] Make theme names translatable The generated .pot file contains the strings with this patch applied. Hope it's ok.
Review of attachment 368891 [details] [review]: Looks good to me. Maybe Robert will want to review and push it, since he's been caring for five-or-more recently. I don't consider this a string freeze break because we are not adding any new strings that were not previously present, we're just making it possible to translate existing strings for the first time. We should still announce the change on gnome-i18n@gnome.org when pushing, though. ::: data/translatable_themes.h @@ +1,1 @@ +NC_("themes", "balls") I think it'd be useful to copy the comment from https://git.gnome.org/browse/gnome-mahjongg/tree/data/translatable_game_names.h into this file, since it's a bit weird to have a header file that's not included in any sources.
Created attachment 368902 [details] [review] Make theme names translatable I also added the comment, although I didn't use a script to generate the header. I created it manually. Let me know if I should change anything else.
Review of attachment 368902 [details] [review]: ::: data/translatable_themes.h @@ +1,2 @@ +/* + * Translatable strings file generated by get_titles.pl. Oh yeah, I missed that. Just change the first line to "translatable strings file," then.
Created attachment 368908 [details] [review] Make theme names translatable Ok, done :)
Review of attachment 368908 [details] [review]: Thanks, this one also looks fine.
Any reason why it’s not accepted-commit_now?
@Michael Catanzaro: you're right regarding the string freeze that we are not breaking translations, just giving a possibility for quick translators to have the theme names translated, the rest will see the same untranslated theme names they saw before the patch. I think I'd still wait for the stable release (that's very soon now), maybe branch gnome-3-28 before that and start pushing the changes to master. That's why my review is commit_after_freeze.
Ok, Piotr convinced me, I'll push this later today to master, along with a notification to gnome-i18n.
This problem has been fixed in the unstable development version. The fix will be available in the next major software release. You may need to upgrade your Linux distribution to obtain that newer version.