GNOME Bugzilla – Bug 672610
camerabin2: check negotiated caps avoid reseting of the pipe
Last modified: 2015-03-04 11:27:43 UTC
Created attachment 210308 [details] [review] patch v1 To avoid useless renegotiation of the pipe we can check for negotiated caps on src_filter and compare it with requested filter. If the caps intersect, avoid restart.
Created attachment 210309 [details] [review] patch v2 changes: - make sure caps are present, before compare it.
Created attachment 210314 [details] [review] patch v3 changelog: - avoid reset if capsfilter set to ANY and new caps set to NULL - rename variables to make clear what kind of caps do we process.
Created attachment 212913 [details] [review] camerabin2: check negotiated caps avoid reseting of the pipe Version with 2 improvements 1) Fix pad leak introduced in the v3 patch 2) Only avoid resetting when the caps is fixed and can be intersected. The reason behind 2 is that we want to force a renegotiation in cases that there might be a new order of preferred caps. Even if one of them intersect, we want to make the source decide using the given order of the structures.
Created attachment 212923 [details] [review] camerabin2: check negotiated caps avoid reseting of the pipe Same as above, but fixes a caps unref issue Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net>
commit e8a3973b8f712cb660fa9675c80c2fd3031acdb2 Author: Oleksij Rempel <bug-track@fisher-privat.net> Date: Thu Mar 22 08:47:57 2012 +0100 camerabin2: check negotiated caps avoid reseting of the pipe To avoid useless renegotiation of the pipe we can check for negotiated caps on src_filter and compare it with requested filter. If the caps intersect, avoid restart. Signed-off-by: Oleksij Rempel <bug-track@fisher-privat.net> https://bugzilla.gnome.org/show_bug.cgi?id=672610