Created attachment 210247 [details]
screenshot

You mean the rounded corners are not anti-aliased? That's because we had to do it manually using cogl as Clutter doesn't support this yet: bug #656877

Created attachment 210386 [details] [review]
call-window: fix incorrect comment

Created attachment 210387 [details] [review]
call-window: use a ClutterBoxLayout to separate previews/toolbar

It's way easier to use a ClutterBoxLayout to ensure the preview
rectangles and the floating toolbar don't overlap.
This way, we can get rid of some complicated manual UI layouting code
and just a margin to set the bottom spacing for the floating toolbar.
Also, this makes the code not dependent on a hardcoded toolbar size
anymore.

Created attachment 210388 [details] [review]
call-window: don't use EmpathyRoundedActor for the floating toolbar

Make this a real toolbar, and add a CSS provider to set the correct
border radius.
In the future, GTK and Adwaita will support an 'OSD' style class that
takes care of this automatically, but right now we have add these few
lines of code.

Created attachment 210389 [details] [review]
call-window: factor out some common code

Review of attachment 210386 [details] [review]:

++

Review of attachment 210387 [details] [review]:

Nice cleanup, thanks!

::: src/empathy-call-window.c
@@ +643,1 @@
+  clutter_bin_layout_add (CLUTTER_BIN_LAYOUT (self->priv->preview_layout), 

You introduced a trailing space here making git a sad panda.

@@ +1667,3 @@
+
+  clutter_bin_layout_add (CLUTTER_BIN_LAYOUT (priv->video_layout),
+      priv->overlay_box, 

trailing space here too

Review of attachment 210388 [details] [review]:

::: src/empathy-call-window.c
@@ +1598,3 @@
+  provider = gtk_css_provider_new ();
+  gtk_css_provider_load_from_data (provider,
+      "#CallFloatingToolbar { border-radius: 6px; }", -1, NULL);

Wouldn't be cleaner to use a proper css file? That's something I'm considering to use anyway: bug #669473

::: src/empathy-call-window.ui
@@ +257,3 @@
             <property name="visible">True</property>
             <property name="homogeneous">False</property>
+            <property name="show_arrow">False</property>

You should remove the homogeneous property to fix:
Gtk-WARNING **: Unknown property: GtkToolbar.homogeneous

Review of attachment 210389 [details] [review]:

++

(In reply to comment #9)

> Wouldn't be cleaner to use a proper css file? That's something I'm considering
> to use anyway: bug #669473

Thanks for the review.

Hmm, as I wrote in the commit message, ideally this wouldn't need additional CSS, but would be available to applications as a "stock" OSD style class, which will happen for 3.6 in all likelihood.
For this reason I preferred having an embedded style provider here instead of an application CSS file (which is usually problematic for themes != Adwaita).

I could probably add a comment in the code to explain it's a temporary workaround if you want.

(In reply to comment #11)

> I could probably add a comment in the code to explain it's a temporary
> workaround if you want.

Sounds good to me.

2.4.0 has been released; feel free to merge.

Attachment 210386 [details] pushed as 60e0705 - call-window: fix incorrect comment
Attachment 210387 [details] pushed as d9c6227 - call-window: use a ClutterBoxLayout to separate previews/toolbar
Attachment 210388 [details] pushed as 3873c83 - call-window: don't use EmpathyRoundedActor for the floating toolbar
Attachment 210389 [details] pushed as d9765b1 - call-window: factor out some common code

Pushed to master, thanks.