GNOME Bugzilla – Bug 672165
rsndvdsrc: post a message with title number and durations
Last modified: 2012-03-16 19:24:48 UTC
Created attachment 209863 [details] [review] rsndvdsrc: post a message with title number and durations
It's useful for me to determine which title is most likely the interesting one (the longest). I'll push soonish if there are no comments.
It will be easier to handle if you make it an array of uint64s instead of having title-duration-xy=1234. Also would make the n-titles field obsolete (as you can get that from the array length). Other than that: yes! :)
Created attachment 209919 [details] [review] rsndvdsrc: post a message with title number and durations
Pushed with an array instead of separate fields, thanks for the review. commit 9ebacafc6ad8deb3be29f1972bd209fbb0c4c4ce Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk> Date: Thu Mar 15 17:10:18 2012 +0000 rsndvdsrc: post a message with title number and durations https://bugzilla.gnome.org/show_bug.cgi?id=672165
Wouldn't it make more sense to use the chapter support for it (bug #540890)?
It looks like a good match, yes. Will this work with hierarchical "chapters" (since a DVD is divided in titles, which are themselves divided in chapters) ? If yes, then sure, this patch can be obsoleted by the chapter stuff. It seems to have recent updates, is this going to be done soon ?
The toc stuff supports hierarchies. When its done, I don't know, the more reviews the better.