After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671736 - Provide translations for "default:LTR" for RTL locales
Provide translations for "default:LTR" for RTL locales
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2012-03-09 17:31 UTC by Florian Müllner
Modified: 2012-03-09 17:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Update Hebrew translations (1.48 KB, patch)
2012-03-09 17:31 UTC, Florian Müllner
committed Details | Review
Add skeleton translations for RTL locales (313.26 KB, patch)
2012-03-09 17:31 UTC, Florian Müllner
committed Details | Review

Description Florian Müllner 2012-03-09 17:31:13 UTC
GNOME Shell used to implement its own text-direction API re-using translations from GTK+. We recently switched to the implementation provided by clutter, but the list of supported locales is less than impressive and those that exist are often incomplete (which is fine given that there are not really any user-visible strings in Clutter).
To avoid a regression for shell users with RTL locales, add/update a couple of translations (based on the list of RTL locales in GTK+).
Comment 1 Florian Müllner 2012-03-09 17:31:16 UTC
Created attachment 209331 [details] [review]
Update Hebrew translations

RTL locales need to translate the "default:LTR" string to have
clutter_actor_get_text_direction() return the expected result;
as GNOME Shell now makes use of that API, users of RTL locales
would be up for an unpleasant surprise, so add the required
translation.
Comment 2 Florian Müllner 2012-03-09 17:31:20 UTC
Created attachment 209332 [details] [review]
Add skeleton translations for RTL locales

RTL locales need to translate the "default:LTR" string to have
clutter_actor_get_text_direction() return the expected result;
as GNOME Shell now makes use of that API, users of RTL locales
would be up for an unpleasant surprise, so add all locales that
translate "default:LTR" to "default:RTL" in GTK+.
Comment 3 Emmanuele Bassi (:ebassi) 2012-03-09 17:33:14 UTC
Review of attachment 209331 [details] [review]:

obviously correct.
Comment 4 Emmanuele Bassi (:ebassi) 2012-03-09 17:34:07 UTC
Review of attachment 209332 [details] [review]:

looks okay to me.
Comment 5 Florian Müllner 2012-03-09 17:56:01 UTC
Attachment 209331 [details] pushed as 52f142c - Update Hebrew translations
Attachment 209332 [details] pushed as 52b1d71 - Add skeleton translations for RTL locales

Thanks for the review! I've notified gnome-i18n of the change, so pushing.