After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671169 - Search fails with "Error invoking Tracker.next_finish()"
Search fails with "Error invoking Tracker.next_finish()"
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
: 674370 675179 (view as bug list)
Depends on: 591480
Blocks:
 
 
Reported: 2012-03-01 21:24 UTC by Giovanni Campagna
Modified: 2012-06-11 14:37 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
TrackerController: don't report an exception for G_IO_ERROR_CANCELLED (1.10 KB, patch)
2012-03-01 22:11 UTC, Giovanni Campagna 		reviewed Details | Review

Description Giovanni Campagna 2012-03-01 21:24:38 UTC 
This happens from the second search on, and it's because when the first search is cancelled, tracker correctly reports G_IO_ERROR_CANCELED, but gnome-documents doesn't recognize it and fails.

This is blocked on better GError support in gjs, but it's just so it's known (I found nothing searching for "next_finish")
Comment 1 Giovanni Campagna 2012-03-01 22:11:44 UTC 
Created attachment 208827 [details] [review]
TrackerController: don't report an exception for G_IO_ERROR_CANCELLED

This error will be emitted normally when a query is cancelled (for
example because a new one is initiated), so we must not report an
error to the user.
Comment 2 Cosimo Cecchi 2012-03-02 15:38:02 UTC 
Review of attachment 208827 [details] [review]:

Makes perfect sense, but we don't have support for this in GJS yet.
If you look at error.js:addQueryError() the code already tries to see if the error is a cancelled one. The hack doesn't really work well in all cases though (maybe Tracker translates or tweaks the stock GIO message).
Comment 3 Giovanni Campagna 2012-03-02 15:50:30 UTC 
Yes, the problem is that the message is localized. You definitely need to match on error code.

(bug 591480 has some gjs code to do so. I've asked to push it for 3.4, waiting for a better implementation in 3.6)
Comment 4 Cosimo Cecchi 2012-03-24 23:09:21 UTC 
Comment on attachment 208827 [details] [review]
TrackerController: don't report an exception for G_IO_ERROR_CANCELLED

Marking as reviewed to remove from the patch queue.
Comment 5 Cosimo Cecchi 2012-04-19 14:22:47 UTC 
*** Bug 674370 has been marked as a duplicate of this bug. ***
Comment 6 Cosimo Cecchi 2012-04-30 19:19:56 UTC 
*** Bug 675179 has been marked as a duplicate of this bug. ***
Comment 7 Jorge Meneses 2012-05-01 22:59:13 UTC 
I'm affected by this issue also, using the last version in the ArchLinux repos 0.4.1-2. Hope it's get fixed soon cause it makes the app quite useless right now.

Regards!
Comment 8 Cosimo Cecchi 2012-05-08 21:40:17 UTC 
*** Bug 675508 has been marked as a duplicate of this bug. ***
Comment 9 Cosimo Cecchi 2012-06-11 14:37:51 UTC 
This is now fixed in git master, since support landed in gjs master too.