After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 671070 - x11: Correct GroupSwitch mask
x11: Correct GroupSwitch mask
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-02-29 16:15 UTC by Bastien Nocera
Modified: 2012-03-04 06:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
x11: Simplify setting the GroupSwitch mask (955 bytes, patch)
2012-02-29 16:15 UTC, Bastien Nocera 		none Details | Review
x11: Correct GroupSwitch mask (1.02 KB, patch)
2012-02-29 16:21 UTC, Bastien Nocera 		committed Details | Review
x11: Simplify XI2 mods state (777 bytes, patch)
2012-02-29 16:22 UTC, Bastien Nocera 		committed Details | Review
x11: Simplify XI2 mods state (777 bytes, patch)
2012-03-04 06:12 UTC, Matthias Clasen 		committed Details | Review
x11: Correct GroupSwitch mask (1.02 KB, patch)
2012-03-04 06:12 UTC, Matthias Clasen 		committed Details | Review

Description Bastien Nocera 2012-02-29 16:15:47 UTC 
I believe this to be correct with XI2.
Comment 1 Bastien Nocera 2012-02-29 16:15:49 UTC 
Created attachment 208696 [details] [review]
x11: Simplify setting the GroupSwitch mask
Comment 2 Bastien Nocera 2012-02-29 16:21:46 UTC 
Created attachment 208698 [details] [review]
x11: Correct GroupSwitch mask

base | latched | locked is incorrect for the group mask,
and the clamping has already been applied.
Comment 3 Bastien Nocera 2012-02-29 16:22:02 UTC 
Created attachment 208699 [details] [review]
x11: Simplify XI2 mods state
Comment 4 Bastien Nocera 2012-02-29 16:22:40 UTC 
Turns that that it's not simply a simplification, but a correction for the group mask.
Comment 5 Matthias Clasen 2012-03-04 06:11:55 UTC 
The following fixes have been pushed:
f3b899f x11: Simplify XI2 mods state
deea79f x11: Correct GroupSwitch mask
Comment 6 Matthias Clasen 2012-03-04 06:12:02 UTC 
Created attachment 208939 [details] [review]
x11: Simplify XI2 mods state
Comment 7 Matthias Clasen 2012-03-04 06:12:05 UTC 
Created attachment 208940 [details] [review]
x11: Correct GroupSwitch mask

base | latched | locked is incorrect for the group mask,
and the clamping has already been applied.