GNOME Bugzilla – Bug 671035
Accounts dialog doesn't update when account goes online
Last modified: 2012-03-15 15:30:48 UTC
If an account is offline, and I got to it in the account dialog, I get a "Go online to edit your personal information." hint. Now, if I go online for this account... then the message is still there. Moving to another account and back to the first one, I can see my personal information. (In the same way: if I'm online with this dialog opened and go offline, I can still see the personal information, instead of having the "Can't edit" hint).
Created attachment 209843 [details] [review] factor out account_is_selected()
Created attachment 209844 [details] [review] create_dialog_content: check if the TpConnection is still valid tp_connection_get_contacts_by_handle() will raise a warning if the TpConnection has been invalidated.
Created attachment 209845 [details] [review] reload the account widget when connection is (dis)connected
+1 but I think it's a bug of TpAccount that it gives invalidated connection. IMO TpAccount should connect "invalidated" signal on its TpConnection and set it to NULL.
Attachment 209843 [details] pushed as 500ef85 - factor out account_is_selected() Attachment 209844 [details] pushed as a3c10ee - create_dialog_content: check if the TpConnection is still valid Attachment 209845 [details] pushed as f17b4a2 - reload the account widget when connection is (dis)connected
(In reply to comment #4) > +1 but I think it's a bug of TpAccount that it gives invalidated connection. > IMO TpAccount should connect "invalidated" signal on its TpConnection and set > it to NULL. I opened https://bugs.freedesktop.org/show_bug.cgi?id=47364