GNOME Bugzilla – Bug 671010
keybindings: add a panel keybinding definition for the screen recorder
Last modified: 2013-05-13 21:36:11 UTC
This exposes the keybinding in System Settings and makes the recorder a bit more visible.
Created attachment 208639 [details] [review] keybindings: add a panel keybinding definition for the screen recorder
Review of attachment 208639 [details] [review]: This keybinding was done in Mutter because we didn't used to have the ability to set up extra keybindings from GNOME Shell - since we have that capability now, I think the keybinding should be moved to GNOME Shell rather than fossilizing it in Mutter via exposed user configuration.
Created attachment 224231 [details] [review] display: Add API to set wm_name / wm_keybindings As plugins can now define their own keyboard shortcuts via meta_display_add_keybinding(), it makes sense for them to expose those shortcuts to System Settings, so add some API to set the properties gnome-control-center uses to pick up wm keybinding settings.
Created attachment 224232 [details] [review] build: Install keybinding files for control-center As some keybindings are now provided by gnome-shell rather than mutter, it makes sense to expose those in System Settings.
Review of attachment 224231 [details] [review]: ::: src/core/display.c @@ +428,2 @@ /** + * meta_set_wm_name: (skip) Why (skip)?
(In reply to comment #5) > ::: src/core/display.c > @@ +428,2 @@ > /** > + * meta_set_wm_name: (skip) > > Why (skip)? Because it is useless from introspection - as the comment says, it only has an effect when called before meta_init(), which we call before setting up introspection and passing control over to javascript.
*** Bug 673059 has been marked as a duplicate of this bug. ***
Review of attachment 224231 [details] [review]: Makes sense, then.
Review of attachment 224232 [details] [review]: Makes sense.
(In reply to comment #2) > Review of attachment 208639 [details] [review]: > > This keybinding was done in Mutter because we didn't used to have the ability > to set up extra keybindings from GNOME Shell - since we have that capability > now, I think the keybinding should be moved to GNOME Shell rather than > fossilizing it in Mutter via exposed user configuration. This was done in https://bugzilla.gnome.org/show_bug.cgi?id=674377
Comment on attachment 224231 [details] [review] display: Add API to set wm_name / wm_keybindings Attachment 224231 [details] pushed as 0593df8 - display: Add API to set wm_name / wm_keybindings
Attachment 224232 [details] pushed as bafe346 - build: Install keybinding files for control-center Got string freeze break approval, pushing.
*** Bug 684396 has been marked as a duplicate of this bug. ***
Does this mean that starting from Gnome 3.6, WM_NAME is changed from "Mutter" to "GNOME Shell"? FYI: This change has broken apps that rely on WM_NAME, e.g. Chrome browser: https://code.google.com/p/chromium/issues/detail?id=239345