After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670904 - Top panel keyboard navigation broken
Top panel keyboard navigation broken
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 673026 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2012-02-27 17:54 UTC by Alejandro Piñeiro Iglesias (IRC: infapi00)
Modified: 2012-03-28 20:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
st-widget: Fix get_focus_chain() (1.32 KB, patch)
2012-02-27 18:53 UTC, Florian Müllner
committed Details | Review

Description Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-02-27 17:54:50 UTC
STEPS TO REPRODUCE IT:

1. Press Ctrl+Alt+Tab
2. Select Top Bar
3. Press right arrow to move until calendar
4. Press right arrow again

EXPECTED OUTCOME

a11y top panel icon selected

ACTUAL OUTCOME

Nothing seems to be selected, but if you press the down arrow a Keyboard Layout Menu is is shown. In the same way if you keep pressing the right arrow nothing happens. In summary, a11y, volume, bluetooth, wifi, battery and user top panel menu are not navigable.

EXTRA NOTES:

Probably it would be good to know why the Keyboar Layout are not available as an icon on the top panel. In the same way, I didn't find any way to open that menu without using keyboard navigation.
Comment 1 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-02-27 18:04:15 UTC
Using git bisect, I found that this started with this commit:

http://git.gnome.org/browse/gnome-shell/commit/?id=72dad591fa4b8b91272ca5978b8b1eb114c0e7de

Related to bug:

https://bugzilla.gnome.org/show_bug.cgi?id=670034

NOTE: in order to test this commit and check that was the first one with this bug, I needed to fix this line:

clutter_actor_destroy_all_children (CLUTTER_ACTOR (cotnainer));

Note cotnainer instead of container.
Comment 2 Florian Müllner 2012-02-27 18:53:26 UTC
Created attachment 208508 [details] [review]
st-widget: Fix get_focus_chain()

The get_focus_chain() implementation in StWidget just returns all
children, it should filter for visible children instead. This
breaks keyboard navigation in various places since commit 72dad591
removed the correct implementation in StContainer.

Good catch.
Comment 3 Jasper St. Pierre (not reading bugmail) 2012-02-27 18:57:28 UTC
Review of attachment 208508 [details] [review]:

Great catch.
Comment 4 Florian Müllner 2012-02-27 19:13:55 UTC
Attachment 208508 [details] pushed as 4005863 - st-widget: Fix get_focus_chain()
Comment 5 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-02-27 19:29:06 UTC
Well, that was really fast. JFYI, I have just tested this commit and works for me. Thanks!
Comment 6 Florian Müllner 2012-03-28 20:22:43 UTC
*** Bug 673026 has been marked as a duplicate of this bug. ***