After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670876 - Missing mnemonics for buttons for vcard attached to email
Missing mnemonics for buttons for vcard attached to email
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Contacts
3.4.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks: 324810
 
 
Reported: 2012-02-27 11:24 UTC by André Klapper
Modified: 2013-09-13 01:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix (8.74 KB, patch)
2012-06-07 06:56 UTC, Dan Vrátil 		committed Details | Review

Description André Klapper 2012-02-27 11:24:58 UTC 
The following buttons miss mnemonics:

#: ../plugins/vcard-inline/vcard-inline.c:208
#: ../plugins/vcard-inline/vcard-inline.c:293
msgid "Show Full vCard"

#: ../plugins/vcard-inline/vcard-inline.c:211
msgid "Show Compact vCard"

#: ../plugins/vcard-inline/vcard-inline.c:302
msgid "Save in Address Book"

Bonus points for not using A as a mnemonic as "Save _As" already uses it.
Comment 1 Dan Vrátil 2012-06-07 06:56:11 UTC 
Created attachment 215821 [details] [review]
Fix

Reuses the parse_html_mnemonics utility originally used for enabling mnemonics in HTML version of itip-formatter.
Comment 2 Milan Crha 2012-06-07 17:21:38 UTC 
Untested, but looks good, please commit to master, only before you do, change "gchar*" to "gchar *" and probably remove the one extra empty line (one chunk with empty line addition in the patch). Thanks.
Comment 3 Dan Vrátil 2012-06-08 09:31:26 UTC 
Committed to master as a6cac3f275db19342e57f2d96141ccfbbf13a8ec

http://git.gnome.org/browse/evolution/commit/?id=a6cac3f275db19342e57f2d96141ccfbbf13a8ec