After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670567 - Power panel references "Screen Settings"
Power panel references "Screen Settings"
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Power
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Richard Hughes
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-21 21:19 UTC by Florian Müllner
Modified: 2012-06-12 13:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
reference to "Brightness and Lock" panel, not "Screen" (1.40 KB, patch)
2012-03-01 14:36 UTC, Javier Jardón (IRC: jjardon)
reviewed Details | Review

Description Florian Müllner 2012-02-21 21:19:07 UTC
The "Screen" panel has been renamed to "Brightness and Lock", so the reference in the power panel should be updated as well.
Comment 1 Javier Jardón (IRC: jjardon) 2012-03-01 14:36:06 UTC
Created attachment 208785 [details] [review]
reference to "Brightness and Lock" panel, not "Screen"
Comment 2 Matthias Clasen 2012-03-02 22:01:25 UTC
Review of attachment 208785 [details] [review]:

Looks right to me, but its a string change, so you'll have to announce it
Comment 3 André Klapper 2012-03-05 16:40:47 UTC
Apart from https://live.gnome.org/TranslationProject/DevGuidelines/Never%20split%20sentences your translator comment will never be seen as it is not immediately preceding the translatable message. Plus it only works for the one next message in the next line, not two lines later.
See https://live.gnome.org/TranslationProject/DevGuidelines/Use%20comments .

You can see the current problem yourself in http://l10n.gnome.org/POT/gnome-control-center.master/gnome-control-center.master.pot

Reopening.
Comment 4 Allan Day 2012-05-30 16:21:27 UTC
How about 'Tip: changing the <a>screen brightness</a> affects how much power is used'?

We don't need to specifically reference the name of the settings panel.
Comment 5 Bastien Nocera 2012-06-12 13:13:18 UTC
commit b9e356412fad645fc55f4790f2022ef192bd1a8a
Author: Bastien Nocera <hadess@hadess.net>
Date:   Tue Jun 12 14:03:25 2012 +0100

    power: Fix reference to "Screen" settings
    
    This also fixes the use of a split string, as mentioned in
    bug #675929.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=670567