GNOME Bugzilla – Bug 670501
Text displayed in Sushi window is dark gray against black under Ambiance/Radiance
Last modified: 2012-03-01 04:53:07 UTC
Original Report: https://bugs.launchpad.net/ubuntu/+source/gnome-sushi/+bug/937148 DistroRelease: Ubuntu 12.04 Package: gnome-sushi 0.2.1-2 When Sushi is used under Ambiance or Radiance, the text displayed is dark gray instead of white. On dimmer displays, this actually makes it harder to read, since the window background is black. See screenshots for a comparison with how it is supposed to look under Adwaita. Adwaita: https://bugs.launchpad.net/ubuntu/+source/gnome-sushi/+bug/937148/+attachment/2762874/+files/Normal%20Sushi%20text%20under%20Adwaita.png Ambiance: https://bugs.launchpad.net/ubuntu/+source/gnome-sushi/+bug/937148/+attachment/2762875/+files/Darker%20Sushi%20text%20under%20Radiance.png
Created attachment 208244 [details] [review] Proposed patch
I guess this a regression of [1]. Doesn't Ambiance provide a dark theme variation? I'd rather not add any additional CSS (and possibly get rid of it completely in the long run), but if we have to do this, I believe setting it in a GtkWindow { } selector is better than in * { }. color is inherited from parent as for CSS spec anyway. [1] http://git.gnome.org/browse/sushi/commit/data/style/gtk-style.css?id=6a4cefd64b5aacadcf820852705183af84517461
Created attachment 208664 [details] [review] Updated patch Ambiance *is* a dark theme variation (Radiance - bright variation). I've attached the updated patch
(In reply to comment #3) > Ambiance *is* a dark theme variation (Radiance - bright variation). > I've attached the updated patch Thanks for the updated patch. If Ambiance is a dark variation though, I still don't understand why this is needed for Sushi. How does Ambiance set its default text color?
This is set to #4c4c4c - see http://bazaar.launchpad.net/~ubuntu-art-pkg/light-themes/trunk/view/head:/Ambiance/gtk-3.0/gtk-widgets.css#L71 and http://bazaar.launchpad.net/~ubuntu-art-pkg/light-themes/trunk/view/head:/Ambiance/gtk-3.0/gtk.css#L3 Adwaita seems to set color to #eeeeec, which is acceptable.
(In reply to comment #5) > This is set to #4c4c4c - see > http://bazaar.launchpad.net/~ubuntu-art-pkg/light-themes/trunk/view/head:/Ambiance/gtk-3.0/gtk-widgets.css#L71 > and > http://bazaar.launchpad.net/~ubuntu-art-pkg/light-themes/trunk/view/head:/Ambiance/gtk-3.0/gtk.css#L3 > > Adwaita seems to set color to #eeeeec, which is acceptable. Right...it's a bit of a weird text color for a dark theme, but it makes sense for Ambiance, since it's not completely dark AFAICS (just the toolbars and the menus). I guess the patch is OK then, feel free to push it.