After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670485 - Simplify session API
Simplify session API
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkApplication
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2012-02-20 21:24 UTC by Allison Karlitskaya (desrt)
Modified: 2012-02-21 00:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GApplication: add g_application_quit() (3.76 KB, patch)
2012-02-20 21:24 UTC, Allison Karlitskaya (desrt) 		reviewed Details | Review
GtkApplication: remove end session API (9.84 KB, patch)
2012-02-20 21:26 UTC, Allison Karlitskaya (desrt) 		committed Details | Review
GtkApplication: simplify session quit handling (4.10 KB, patch)
2012-02-20 21:27 UTC, Allison Karlitskaya (desrt) 		committed Details | Review
bloatpad: adjust to G(tk)Application 'quit' change (1.65 KB, patch)
2012-02-21 00:16 UTC, Allison Karlitskaya (desrt) 		committed Details | Review
GApplication: add g_application_quit() (3.82 KB, patch)
2012-02-21 00:21 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2012-02-20 21:24:26 UTC 
- add g_application_quit()

  - remove the quit signal from GtkApplication and call
    g_application_quit() directly

  - remove the session-ending API
Comment 1 Allison Karlitskaya (desrt) 2012-02-20 21:24:30 UTC 
Created attachment 208063 [details] [review]
GApplication: add g_application_quit()

A long requested feature; this quits the application immediately,
ignoring the hold count.
Comment 2 Allison Karlitskaya (desrt) 2012-02-20 21:26:59 UTC 
Created attachment 208064 [details] [review]
GtkApplication: remove end session API

This seems a bit "too powerful" and unlikely to be used by most
applications.  Remove it from now, until someone comes up with a strong
desire for it.
Comment 3 Allison Karlitskaya (desrt) 2012-02-20 21:27:04 UTC 
Created attachment 208065 [details] [review]
GtkApplication: simplify session quit handling

Instead of firing a 'quit' signal and expecting the application to do
something that will cause it to quit, just call the new
g_application_quit() API for ourselves.
Comment 4 Matthias Clasen 2012-02-21 00:13:59 UTC 
Review of attachment 208063 [details] [review]:

Looks fine to me

::: gio/gapplication.c
@@ +1720,3 @@
+void
+g_application_quit (GApplication *application)
+{

A g_return_if_fail would be customary here
Comment 5 Allison Karlitskaya (desrt) 2012-02-21 00:16:31 UTC 
Created attachment 208071 [details] [review]
bloatpad: adjust to G(tk)Application 'quit' change
Comment 6 Matthias Clasen 2012-02-21 00:16:41 UTC 
Review of attachment 208064 [details] [review]:

I already agreed to this in the kitchen.
Comment 7 Allison Karlitskaya (desrt) 2012-02-21 00:21:22 UTC 
Created attachment 208072 [details] [review]
GApplication: add g_application_quit()

A long requested feature; this quits the application immediately,
ignoring the hold count.
Comment 8 Matthias Clasen 2012-02-21 00:22:24 UTC 
Review of attachment 208065 [details] [review]:

Agreed to this one too. I expect that we will have requests for the signal, but we can wait for it.
Comment 9 Allison Karlitskaya (desrt) 2012-02-21 00:22:24 UTC 
Comment on attachment 208072 [details] [review]
GApplication: add g_application_quit()

Attachment 208072 [details] pushed as ed51975 - GApplication: add g_application_quit()
Comment 10 Allison Karlitskaya (desrt) 2012-02-21 00:23:59 UTC 
Comment on attachment 208064 [details] [review]
GtkApplication: remove end session API

Attachment 208064 [details] pushed as 659c713 - GtkApplication: remove end session API
Comment 11 Matthias Clasen 2012-02-21 00:24:06 UTC 
Review of attachment 208071 [details] [review]:

ok
Comment 12 Matthias Clasen 2012-02-21 00:24:16 UTC 
Review of attachment 208071 [details] [review]:

ok
Comment 13 Allison Karlitskaya (desrt) 2012-02-21 00:24:58 UTC 
Comment on attachment 208065 [details] [review]
GtkApplication: simplify session quit handling

Attachment 208065 [details] pushed as ef2df58 - GtkApplication: simplify session quit handling
Comment 14 Allison Karlitskaya (desrt) 2012-02-21 00:31:50 UTC 
Attachment 208071 [details] pushed as 8ec0cfd - bloatpad: adjust to G(tk)Application 'quit' change