After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670319 - [Patch] polkit-agent: Fix SEGV with polkit 104 and under
[Patch] polkit-agent: Fix SEGV with polkit 104 and under
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal critical
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-02-17 19:51 UTC by Marc-Antoine Perennou
Modified: 2012-02-19 11:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
fix the SEGV (1.55 KB, patch)
2012-02-17 19:51 UTC, Marc-Antoine Perennou
needs-work Details | Review
fix the SEGV (1.71 KB, patch)
2012-02-17 20:12 UTC, Marc-Antoine Perennou
committed Details | Review

Description Marc-Antoine Perennou 2012-02-17 19:51:45 UTC
Created attachment 207900 [details] [review]
fix the SEGV

When running systemd, polkit doesn't set the error when returning false from g_initable_init, so error->message SEGV when we display it.
Comment 1 Owen Taylor 2012-02-17 20:03:07 UTC
Review of attachment 207900 [details] [review]:

could you improve subject to something like:

 pokit-agent: fix segfault when we we fail to get the current session

and add a comment in the code like

 /* older versions of polkit don't properly set error on failure */

otherwise seems fine
Comment 2 Marc-Antoine Perennou 2012-02-17 20:12:50 UTC
Created attachment 207902 [details] [review]
fix the SEGV
Comment 3 Owen Taylor 2012-02-18 19:26:30 UTC
Review of attachment 207902 [details] [review]:

Looks good, thanks
Comment 4 drago01 2012-02-19 11:29:19 UTC
Comment on attachment 207902 [details] [review]
fix the SEGV

This got pushed as b67138b5 so we should just close this.