GNOME Bugzilla – Bug 670316
goffice 0.8.x fails to build with pcre 8.30
Last modified: 2013-01-13 18:47:42 UTC
Created attachment 207880 [details] [review] Fix build with pcre 8.30 pcre 8.30 removed (after having it marked obsoleted for 10 years) the api function pcre_info(). The attached patch changes pcre_info to pcre_fullinfo, which is the supposed replacement.
(In reply to comment #0) > Created an attachment (id=207880) [details] [review] > Fix build with pcre 8.30 > > pcre 8.30 removed (after having it marked obsoleted for 10 years) the api > function pcre_info(). > > The attached patch changes pcre_info to pcre_fullinfo, which is the supposed > replacement. Encountered same bug on gentoo (https://bugs.gentoo.org/show_bug.cgi?id=404271); goffice-0.8.17 builds successfully and appears to function OK with your patch, thanks. //Rolf
Thanks for the patch. GOffice does not link against pcre anymore in the development branch. Keeping this bug open until we release next stable version, no new 0.8.x release is planned.
Alternatively use a newer glib. 2.16 or newer should do and the code in question should not be used. If you already have 2.16 (and see G_REGEX_ERROR_STRAY_BACKSLASH in the glib header files) then something else is wrong.
But <2.31.x because you can only include glib.h directly with newer versions and so you need: sed -e 's:glib/gregex.h:glib.h:' -i configure.in
(In reply to comment #3) > Alternatively use a newer glib. 2.16 or newer should do and the code in > question should not be used. > > If you already have 2.16 (and see G_REGEX_ERROR_STRAY_BACKSLASH in the > glib header files) then something else is wrong. Well, we are running newer glib version for a long time on Gentoo :-/
Created attachment 212448 [details] [review] remove pcre workaround and drop support for <glib-2.16 This bug is caused by goffice's configure for whatever reason failing to detect G_REGEX_ERROR_STRAY_BACKSLASH in glib headers and therefore enabling the pcre workaround (incompatible with pcre-8.30) that was needed for truly ancient versions of glib. IMHO the correct solution to this problem is to simply remove the pcre workaround and completely drop support for glib versions before 2.15.1. Goffice-0.8 already depends on >=gobject-2.16 and >=gmodule-2.16, so allowing a dependency on older glib versions really doesn't make sense.
(In reply to comment #6) > This bug is caused by goffice's configure for whatever reason failing to detect > G_REGEX_ERROR_STRAY_BACKSLASH in glib headers and therefore enabling the pcre > workaround (incompatible with pcre-8.30) that was needed for truly ancient > versions of glib. As I already mentioned: since glib-2.31.x you can only include glib.h. The test for G_REGEX_ERROR_STRAY_BACKSLASH support includes glib/gregex.h so the fix is: sed -e 's:glib/gregex.h:glib.h:' -i configure.in I'm not sure about the backward compatibility, at least 2.30 works well.
Obsolete or fixed, depending on your viewpoint. 0.10 is out and doesn't have this issue.