After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670312 - Orca presents "panelActivities button" instead of "Activities button" when that button is focused
Orca presents "panelActivities button" instead of "Activities button" when th...
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-02-17 17:59 UTC by Alejandro Piñeiro Iglesias (IRC: infapi00)
Modified: 2012-02-29 15:28 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
a11y: setting a proper name for Activities button (1.18 KB, patch)
2012-02-17 17:59 UTC, Alejandro Piñeiro Iglesias (IRC: infapi00)
reviewed Details | Review

Description Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-02-17 17:59:10 UTC
Created attachment 207876 [details] [review]
a11y: setting a proper name for Activities button

STEPS TO REPRODUCE

1. Orca running
2. Select Top Bar with Ctrl+Alt+Tab 
3. Activities button is the first focused

NOTES

At the beginning I didn't realize that this was a problem, as I thought that this "panel" was just a intermediate object receiving the focus, but on the javascript code itself, it receives the name "panelActivities". I didn't see any other place of the code using that name. In the patch attached I just removed this name, and set the Activities button label_actor, as there are already a label with the text (and translated).
Comment 1 Dan Winship 2012-02-28 18:00:05 UTC
Comment on attachment 207876 [details] [review]
a11y: setting a proper name for Activities button

>-        this.actor.name = 'panelActivities';

leave that in; it's useful for debugging. (It shows up if you convert the actor to a string, eg, as part of a log message.)

otherwise good
Comment 2 Alejandro Piñeiro Iglesias (IRC: infapi00) 2012-02-29 15:28:37 UTC
Patch committed after the chang(In reply to comment #1)
> (From update of attachment 207876 [details] [review])
> >-        this.actor.name = 'panelActivities';
> 
> leave that in; it's useful for debugging. (It shows up if you convert the actor
> to a string, eg, as part of a log message.)
> 
> otherwise good

Patch committed after the changes proposed.

Note that in order to avoid Orca presenting "Activities panelActitivities" you need this clutter commit:

http://git.gnome.org/browse/clutter/commit/?id=dde5da1dd8f75c3522f3b89417f3e5eb5a414a25

Closing bug.