Created attachment 207750 [details] [review]
accounts-dialog: don't automatically open the add account

This legacy code isn't used since a while as the assistant is displayed if
there is no account.

Created attachment 207751 [details] [review]
accounts-dialog: remove hbox_protocol

It's not used any more since we moved adding account to a separated dialog.

Created attachment 207752 [details] [review]
accounts-dialog: move the 'no protocol' message to a different page

It's cleaner that way

Created attachment 207753 [details] [review]
accounts_dialog_add_account: select if that's the first account added

This ensures we'll select the first imported account.

Review of attachment 207750 [details] [review]:

Okay.

Review of attachment 207751 [details] [review]:

Okay.

Review of attachment 207751 [details] [review]:

Okay.

Review of attachment 207751 [details] [review]:

Okay.

Review of attachment 207752 [details] [review]:

Yup yup, I like these kinds of notebooks.

::: src/empathy-accounts-dialog.ui
@@ +218,3 @@
+                  <object class="GtkLabel" id="label_no_protocol">
+                    <property name="visible">True</property>
+                    <property name="left_padding">12</property>

I know this isn't new, but protocol should really be plural, and this message should probably be “No protocol backends installed” (it's not the protocols you install, it's the backends). But if you want to minimize translation churn for this relative edge case, leave it. :)

Review of attachment 207753 [details] [review]:

::: src/empathy-accounts-dialog.c
@@ +1870,3 @@
   if (!accounts_dialog_get_account_iter (dialog, account, &iter))
     {
+      /* Select the account if that's the first added */

s/that's/it's/.

Review of attachment 207752 [details] [review]:

::: src/empathy-accounts-dialog.ui
@@ +218,3 @@
+                  <object class="GtkLabel" id="label_no_protocol">
+                    <property name="visible">True</property>
+                    <property name="left_padding">12</property>

That's fine. I added a commit changing the message.

Created attachment 207757 [details] [review]
accounts-dialog: improve the 'no protocol installed' message

Review of attachment 207753 [details] [review]:

::: src/empathy-accounts-dialog.c
@@ +1870,3 @@
   if (!accounts_dialog_get_account_iter (dialog, account, &iter))
     {
+      /* Select the account if that's the first added */

Thanks, fixed.

Attachment 207750 [details] pushed as ce4c4dc - accounts-dialog: don't automatically open the add account
Attachment 207751 [details] pushed as 7b55432 - accounts-dialog: remove hbox_protocol
Attachment 207752 [details] pushed as 55fab80 - accounts-dialog: move the 'no protocol' message to a different page
Attachment 207753 [details] pushed as 4adfd6f - accounts_dialog_add_account: select if that's the first account added
Attachment 207757 [details] pushed as 3c51d10 - accounts-dialog: improve the 'no protocol installed' message