After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 670148 - iconGrid: Split vertical/horizontal item size
iconGrid: Split vertical/horizontal item size
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-02-15 16:47 UTC by Florian Müllner
Modified: 2012-02-15 21:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
iconGrid: Split vertical/horizontal item size (4.97 KB, patch)
2012-02-15 16:47 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2012-02-15 16:47:28 UTC 
See patch. Long term it'd be nice to kill the custom search provider altogether, but for now just fix what we have ...
Comment 1 Florian Müllner 2012-02-15 16:47:33 UTC 
Created attachment 207672 [details] [review]
iconGrid: Split vertical/horizontal item size

IconGrid items used to be square, so a single size value made
perfect sense. However, as contact search uses rectangular items,
using a single size is wrong - the allocated height ends up twice
the size of the visible height, which is particularly visible if
another provider displays results below contact results.
Comment 2 Jasper St. Pierre (not reading bugmail) 2012-02-15 20:47:39 UTC 
Review of attachment 207672 [details] [review]:

Makes sense.
Comment 3 Florian Müllner 2012-02-15 21:16:16 UTC 
Attachment 207672 [details] pushed as 1c0c42e - iconGrid: Split vertical/horizontal item size