After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669993 - Contact search results stick out like a sore thumb
Contact search results stick out like a sore thumb
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-02-13 15:10 UTC by Allan Day
Modified: 2012-02-13 18:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
theme patch (1.40 KB, patch)
2012-02-13 15:18 UTC, Allan Day 		accepted-commit_now Details | Review
screenshot (681.07 KB, image/png)
2012-02-13 15:21 UTC, Allan Day 		  Details

Description Allan Day 2012-02-13 15:10:41 UTC 
They're white and flat, meaning that they don't blend in nicely.
Comment 1 Allan Day 2012-02-13 15:18:32 UTC 
Created attachment 207452 [details] [review]
theme patch

A patch might not be completely necessary here, but I feel like someone should say OK. :)

I removed text-align: center; because it didn't make sense to me, but maybe I'm missing something...
Comment 2 Allan Day 2012-02-13 15:21:13 UTC 
Created attachment 207453 [details]
screenshot

Here's a screenshot of the result. One potential issue with this approach is that names can get ellipsized very easily.
Comment 3 Giovanni Campagna 2012-02-13 15:52:07 UTC 
Review of attachment 207452 [details] [review]:

You wanted someone to say OK, so OK
Comment 4 Jasper St. Pierre (not reading bugmail) 2012-02-13 16:14:06 UTC 
Not enough padding in my opinion, and too much border-radius, but sure.
Comment 5 Jasper St. Pierre (not reading bugmail) 2012-02-13 17:53:39 UTC 
Patch is pushed.
Comment 6 Allan Day 2012-02-13 17:55:46 UTC 
Yep:

http://git.gnome.org/browse/gnome-shell/commit/?id=de0116d8c8cca1525aac29e6a61d3b6dc97e9c71

I'm sure it can be improved, but it's better than what we had before.
Comment 7 Allan Day 2012-02-13 18:04:33 UTC 
Apologies, don't know how I changed the status there.