After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669947 - gtkuimanager: clarify @pos of insert_action_group
gtkuimanager: clarify @pos of insert_action_group
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Documentation
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2012-02-12 23:28 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2012-02-20 10:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkuimanager: clarify @pos of insert_action_group (965 bytes, patch)
2012-02-12 23:28 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2012-02-12 23:28:09 UTC 
gtk_ui_manager_insert_action_group does not mention that internally it
handles a GList of action groups, and hence, it is valid to pass a
negative or larger-than-total @pos parameter.

I propose this small update to the gtk-doc string. Alternatively we
could mention that it is a GList internally, but I think just mentioning
the pragmatical consequence of that is enough.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2012-02-12 23:28:11 UTC 
Created attachment 207411 [details] [review]
gtkuimanager: clarify @pos of insert_action_group

Mention that it is possible for it to be negative, or larger than the
current number of action groups.
Comment 2 Matthias Clasen 2012-02-13 20:00:30 UTC 
Review of attachment 207411 [details] [review]:

Sure, looks fine
Comment 3 David King 2012-02-20 10:13:10 UTC 
Comment on attachment 207411 [details] [review]
gtkuimanager: clarify @pos of insert_action_group

Pushed to master as commit c84d58ce1b50c4181f84d0146de902ef9683428e.