After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669785 - Build fixes for COGL master (1.9.x)
Build fixes for COGL master (1.9.x)
Status: RESOLVED FIXED
Product: cogl
Classification: Platform
Component: general
unspecified
Other Windows
: Normal normal
: ---
Assigned To: Cogl maintainer(s)
Cogl maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-02-10 03:28 UTC by Fan, Chun-wei
Modified: 2012-02-13 13:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use COGL_HAS_GLIB_SUPPORT and predefine COGL_SYSDEF_POLL* (1.98 KB, patch)
2012-02-10 03:28 UTC, Fan, Chun-wei
none Details | Review
Remove stray ';' from cogl-in-gles-core-functions.h (1.03 KB, patch)
2012-02-10 03:30 UTC, Fan, Chun-wei
none Details | Review
Updates to cogl.symbols (17.94 KB, patch)
2012-02-10 03:32 UTC, Fan, Chun-wei
none Details | Review
Filter out the SDL winsys code for VS project completion (2.24 KB, patch)
2012-02-10 03:35 UTC, Fan, Chun-wei
none Details | Review

Description Fan, Chun-wei 2012-02-10 03:28:36 UTC
Created attachment 207226 [details] [review]
Use COGL_HAS_GLIB_SUPPORT and predefine COGL_SYSDEF_POLL*

Hi,

I was building COGL lately on Visual C++ and found there are some issues during the build, where I think the following patches need to be made.

The first one is regarding the pre-defined cogl-defines.h(.win32|.win32_SDL) as COGL_HAS_GLIB_SUPPORT and COGL_SYSDEF_POLL* values need to be defined for the build and usage of COGL.  Please note that I am not currently adding support to build COGL without GLIB due to its use in Clutter, which AFAIK uses GLib and other GNOME platform libraries quite extensively.
Comment 1 Fan, Chun-wei 2012-02-10 03:30:44 UTC
Created attachment 207227 [details] [review]
Remove stray ';' from cogl-in-gles-core-functions.h

Next up is the removal of a stray ';' from cogl-in-gles-core-functions.h which some compilers don't like at all.
Comment 2 Fan, Chun-wei 2012-02-10 03:32:37 UTC
Created attachment 207228 [details] [review]
Updates to cogl.symbols

Next up is the updates that are necessary to cogl.symbols, as it is getting out of date, especially due to additional/change of APIs and removal of the _EXP suffix of functions.
Comment 3 Fan, Chun-wei 2012-02-10 03:35:07 UTC
Created attachment 207229 [details] [review]
Filter out the SDL winsys code for VS project completion

Last but not least, this is more of a paranoid fix on my part-don't include the SDL winsys code when Visual C++ project files are expanded during 'make dist' as it could be included in the projects twice, which can cause trouble.  These files are handled directly in the projects as they are only built under certain configs.

With blessings, thank you!
Comment 4 Neil Roberts 2012-02-13 13:42:25 UTC
I've pushed the patches as e654e3f..9b87e86. Thank you!