After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669776 - Rename CSS selectors for password prompts
Rename CSS selectors for password prompts
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks: 652459
 
 
Reported: 2012-02-09 20:58 UTC by Stef Walter
Modified: 2012-02-10 08:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Rename CSS selectors for password prompts (12.17 KB, patch)
2012-02-09 20:58 UTC, Stef Walter 		accepted-commit_now Details | Review

Description Stef Walter 2012-02-09 20:58:07 UTC 
Recommendend by fmuellner in bug 652459:
> I know we do that as well in networkAgent.js, but it still feels wrong - in my
> opinion, it would be better to either rename 'polkit-foo' to something more
> general like 'password-foo' (should be done in a separate patch), 

Used 'prompt-' as the prefix for the selectors, as the same selectors are used by non password prompts like Wanda.
Comment 1 Stef Walter 2012-02-09 20:58:10 UTC 
Created attachment 207218 [details] [review]
Rename CSS selectors for password prompts

 * Use .prompt-xxx selectors instead of .polkit-xxx
Comment 2 Florian Müllner 2012-02-09 21:50:54 UTC 
Review of attachment 207218 [details] [review]:

Looks good to me, except for the commit message's body. How about something like:

Use .prompt-xxx selectors instead of .polkit-xxx, as the selectors are now used by various non-polkit dialogs as well.
Comment 3 Stef Walter 2012-02-10 08:17:29 UTC 
Thanks. Merged into master.