After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669736 - ephy-window: use tab-close-request to avoid code duplication
ephy-window: use tab-close-request to avoid code duplication
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-09 11:02 UTC by Diego Escalante Urrelo (not reading bugmail)
Modified: 2012-02-10 20:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ephy-window: use tab-close-request to avoid code duplication (1.46 KB, patch)
2012-02-09 11:02 UTC, Diego Escalante Urrelo (not reading bugmail) 		committed Details | Review

Description Diego Escalante Urrelo (not reading bugmail) 2012-02-09 11:02:56 UTC 
Instead of two code paths, just use notebook_page_close_request_cb.
The removed one was not checking for downloads anyway, so it was evil.
Comment 1 Diego Escalante Urrelo (not reading bugmail) 2012-02-09 11:02:58 UTC 
Created attachment 207174 [details] [review]
ephy-window: use tab-close-request to avoid code duplication

There were two paths checking for modified forms and downloads on tab
closing. Instead of duplication code, make EphyEmbedContainer
impl_remove_child trigger ::tab-close-request on EphyNotebook.
Comment 2 Xan Lopez 2012-02-10 10:33:14 UTC 
Review of attachment 207174 [details] [review]:

Makes sense.
Comment 3 Diego Escalante Urrelo (not reading bugmail) 2012-02-10 20:11:16 UTC 
Done!

Attachment 207174 [details] pushed as e2576b4 - ephy-window: use tab-close-request to avoid code duplication