After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669676 - Opening gnome-contacts from Chat dialog doesn't work for metacontacts
Opening gnome-contacts from Chat dialog doesn't work for metacontacts
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Chat
3.3.x
Other Linux
: Normal normal
: 3.4
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-02-08 14:38 UTC by Frederic Peters
Modified: 2012-02-15 09:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add empathy_individual_manager_lookup_by_contact() (3.38 KB, patch)
2012-02-10 13:54 UTC, Guillaume Desmottes 		none Details | Review
add empathy_ensure_individual_from_tp_contact() (1.80 KB, patch)
2012-02-10 13:54 UTC, Guillaume Desmottes 		committed Details | Review
empathy-chat: use empathy_ensure_individual_from_tp_contact() (980 bytes, patch)
2012-02-10 13:54 UTC, Guillaume Desmottes 		committed Details | Review
empathy-chat: keep the individual manager alive as a cache (1.62 KB, patch)
2012-02-10 13:54 UTC, Guillaume Desmottes 		committed Details | Review
add empathy_individual_manager_lookup_by_contact() (2.64 KB, patch)
2012-02-15 09:48 UTC, Guillaume Desmottes 		committed Details | Review

Description Frederic Peters 2012-02-08 14:38:59 UTC 
Opening gnome-contacts on a contact works fine from the contact list context menu, but doesn't work from the chat dialog menu item. gnome-contacts gets called with an id that doesn't appear to exist (looking at folks-inspect individuals).

This only happens on metacontacts.
Comment 1 Guillaume Desmottes 2012-02-10 12:48:22 UTC 
Fixing this properly (in a more optimissed way) needs bug #658576 which is not going to happen soon so I'll go with a less good one for now (preparing the full folks aggregator in empathy-chat).
Comment 2 Guillaume Desmottes 2012-02-10 13:54:47 UTC 
Created attachment 207249 [details] [review]
add empathy_individual_manager_lookup_by_contact()
Comment 3 Guillaume Desmottes 2012-02-10 13:54:50 UTC 
Created attachment 207250 [details] [review]
add empathy_ensure_individual_from_tp_contact()
Comment 4 Guillaume Desmottes 2012-02-10 13:54:52 UTC 
Created attachment 207251 [details] [review]
empathy-chat: use empathy_ensure_individual_from_tp_contact()

This ensures we'll pass the right individual ID to gnome-contacts when opening
a meta-contact.
Comment 5 Guillaume Desmottes 2012-02-10 13:54:55 UTC 
Created attachment 207252 [details] [review]
empathy-chat: keep the individual manager alive as a cache
Comment 6 Guillaume Desmottes 2012-02-15 09:48:38 UTC 
Created attachment 207612 [details] [review]
add empathy_individual_manager_lookup_by_contact()
Comment 7 Guillaume Desmottes 2012-02-15 09:52:26 UTC 
Attachment 207250 [details] pushed as 54bd693 - add empathy_ensure_individual_from_tp_contact()
Attachment 207251 [details] pushed as fac52e2 - empathy-chat: use empathy_ensure_individual_from_tp_contact()
Attachment 207252 [details] pushed as 84e286a - empathy-chat: keep the individual manager alive as a cache
Attachment 207612 [details] pushed as 894ce49 - add empathy_individual_manager_lookup_by_contact()