After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669675 - [PATCH] mpegdemux/dvddemux randomly losing packets
[PATCH] mpegdemux/dvddemux randomly losing packets
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-ugly
git master
Other Linux
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2012-02-08 14:35 UTC by Jindrich Makovicka
Modified: 2012-11-11 17:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Avoid skipping of a partial start code when exhausting cache buffer (479 bytes, patch)
2012-02-08 14:35 UTC, Jindrich Makovicka 		none Details | Review

Description Jindrich Makovicka 2012-02-08 14:35:39 UTC 
Created attachment 207107 [details] [review]
Avoid skipping of a partial start code when exhausting cache buffer

Hi,

in gstmpegpacketize.c, when a packet start code appears across the end of the cache chunk boundary, it is not properly recognized by find_start_code().

The attached patch changes the behavior of find_start_code() so its next call continues at the next byte instead of skipping all four bytes previously checked.
Comment 1 David Schleef 2012-02-22 03:07:24 UTC 
On first look, this appears to do bad things in the corner case of having less than 5 bytes left in the stream.
Comment 2 Tim-Philipp Müller 2012-11-11 17:44:03 UTC 
Thanks for the patch, but this mpeg demuxer has been removed from GStreamer 1.x in favour of the mpeg PS demuxer from gst-plugins-bad, and the 0.10 branch is no longer maintained I'm afraid.

Would still be great if you could make sure that the issue you were seeing does not exist with the mpegpsdemux element from -bad. Thanks!