After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 669660 - Allow "Flash" to be called separately
Allow "Flash" to be called separately
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2012-02-08 12:21 UTC by Bastien Nocera
Modified: 2012-02-20 20:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
dbus: Add FlashArea method (1.54 KB, patch)
2012-02-09 18:57 UTC, drago01 		committed Details | Review

Description Bastien Nocera 2012-02-08 12:21:14 UTC 
The flash functionality added in bug 668618 would be useful for applications like Totem (screenshot of the currently playing film), or cheese (Full flash when taking a picture of the user), but it's currently impossible to use it without taking a screenshot.
Comment 1 drago01 2012-02-09 18:57:27 UTC 
Created attachment 207210 [details] [review]
dbus: Add FlashArea method

Add a new dbus method that takes an area (x, y, width, height) and fires a
flashspot on it.

This would be useful for applications like totem and cheese.
Comment 2 Owen Taylor 2012-02-20 20:47:45 UTC 
Hmm, some feeling that this is too raw - and should be higher level, but I guess it's not too bad in the expected use cases:

 A) entire window with decorations
    Use gdk_window_get_frame_extents()

 B) Some area of window
    Use gdk_window_get_origin()

 C) entire screen
    Use gdk_screen_get_width/height()
Comment 3 Owen Taylor 2012-02-20 20:50:02 UTC 
Review of attachment 207210 [details] [review]:

Looks fine
Comment 4 drago01 2012-02-20 20:53:05 UTC 
Attachment 207210 [details] pushed as 14b92a4 - dbus: Add FlashArea method