Changed the text, padding left to do.

I can see "Add..." making some sense, though: "you add a friend to your contact list by creating a new entry".

The decision is whether the button should refer to your friend ("Add...") or the contact entry itself ("New"). I'd go with the first option, but clearly both are understandable.

Consider how this is different from creating a new document: the document doesn't exist before you press the button, but your friend does.

Should the fact that the button it don't line up with the A in Activities of the shell (similar to Web bug #679348) be added to this bug report, or should I create a new one about that?

Andreas: Please file a new bug about that.

Created attachment 229000 [details] [review]
patch

Here's a one liner to fix the button size.

Hmm, that just sets the minimal size to a hardcoded size. What if the translated string is longer than that?

Created attachment 229736 [details]
mockup experiments

(In reply to comment #6)
> Hmm, that just sets the minimal size to a hardcoded size. What if the
> translated string is longer than that?

I think we ideally want to combine a minimum width with horizontal padding. That way we ensure that the button never shrinks to an unusable size, and we avoid making the button too huge if the string is long (see the attachment).

I investigated setting internal padding via CSS but it didn't seem to work.

I had the same concern and used gtk_misc_set_padding. Maybe does it fit your need?

While we are at it: am I the only one who thinks that the "New" button being the only item in that horizontal array looks terrible? It seems like a waste of screen estate. I would definitely move it elsewhere, perhaps next to the search entry using only a '+' icon. Whatever you prefer, but where it stands now, it looks pretty bad.

(In reply to comment #9)
> While we are at it: am I the only one who thinks that the "New" button being
> the only item in that horizontal array looks terrible? It seems like a waste of
> screen estate. I would definitely move it elsewhere, perhaps next to the search
> entry using only a '+' icon. Whatever you prefer, but where it stands now, it
> looks pretty bad.

The toolbar has changed in master.

(In reply to comment #10)
> The toolbar has changed in master.

Yeah, I think we can close this.